Update protoc-gen-go comment to fix make check
#257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sergi Castro <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #257 +/- ##
=======================================
Coverage ? 90.64%
=======================================
Files ? 25
Lines ? 1603
Branches ? 0
=======================================
Hits ? 1453
Misses ? 107
Partials ? 43 |
nacx
reviewed
May 13, 2024
There was a problem hiding this comment.
Can we also pin protoc-gen-go to avoid this happening randomly? Let's change this line:
authservice/config/buf.gen.yaml
Line 23 in f2ef0e4
to plugin: buf.build/protocolbuffers/go:v1.34.1
Signed-off-by: Sergi Castro <[email protected]>
|
Good point, version pinned! |
nacx
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we update the
proto-gen-godependency we should be runningmake generateto update the version comment in the generated.pb.gofiles.