-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a logger to log the calls to the Identity Provider #250
Conversation
Signed-off-by: Ignasi Barrera <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM.
But I have some doubts about all:debug,idp:none
, weren't we accepting the keyword default
? I think it would apply better to this case: default:debug,idp:none
Not really. default is an actual logging scope, that is used when no other loggers are configured. It could be misleading, yes... We could consider removing that logger to make this more understandable? But probably in another PR |
Signed-off-by: Ignasi Barrera <[email protected]>
Ok, let's keep track of the default keyword in a separate PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nacx, sergicastro The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This adds the
idp
logger that will log all the calls made to the Identity Provider such as the token endpoint calls. It also adds more information to some of the existing loggers. Currently, there are no means to see what requests are being made as part of the OIDC flow, and troubleshooting the responses from the IdP was challenging. This logger will facilitate better understand the flow.It is important to note that the
idp
logger may expose sensitive information in the logs, such as theclient_secret
or the tokens being issued. Use with care and do not enable it by default. To make it easier to set default log levels and just override some, I've changed a bit the behavior of the logging settings, to allow things like:all:debug,idp:none
. Previously, if theall
logger was set, all the other log levels were ignored. Now, if theall
logger is present, it will be used as the default, then individual loggers will be configured on top.