Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check on GLIBC requirements #219

Merged
merged 15 commits into from
Apr 6, 2022
Merged

Conversation

dio
Copy link
Collaborator

@dio dio commented Apr 5, 2022

This makes sure we can run on lte GLIBC_2.28. This adds a test using objdump -T (scripted in Go) to check the GLIBC version.

Supersedes #218.

Signed-off-by: Dhi Aurrahman [email protected]

dio added 5 commits April 4, 2022 21:10
Signed-off-by: Dhi Aurrahman <[email protected]>
Signed-off-by: Dhi Aurrahman <[email protected]>
Signed-off-by: Dhi Aurrahman <[email protected]>
Signed-off-by: Dhi Aurrahman <[email protected]>
Signed-off-by: Dhi Aurrahman <[email protected]>
dio added 5 commits April 5, 2022 12:42
Signed-off-by: Dhi Aurrahman <[email protected]>
Signed-off-by: Dhi Aurrahman <[email protected]>
Signed-off-by: Dhi Aurrahman <[email protected]>
Signed-off-by: Dhi Aurrahman <[email protected]>
Signed-off-by: Dhi Aurrahman <[email protected]>
Signed-off-by: Dhi Aurrahman <[email protected]>
Tools.mk Show resolved Hide resolved
Signed-off-by: Dhi Aurrahman <[email protected]>
@dio
Copy link
Collaborator Author

dio commented Apr 5, 2022

/assign @incfly

Signed-off-by: Dhi Aurrahman <[email protected]>
@dio
Copy link
Collaborator Author

dio commented Apr 5, 2022

@incfly you can download the zip file on: https://github.com/istio-ecosystem/authservice/actions/runs/2094663257 (I uploaded the binary as an artifact), then you can validate it inside the ubi8 image.

$ # unzip the downloaded zip file
$ chmod +x /path/to/auth_server.stripped
$ docker run --rm -it -v /path/to/auth_server.stripped:/usr/local/bin/auth_server registry.access.redhat.com/ubi8/ubi:8.5-236.1648460182 ldd /usr/local/bin/auth_server
        linux-vdso.so.1 (0x00007ffe440c9000)
        libm.so.6 => /lib64/libm.so.6 (0x00007f3665461000)
        libpthread.so.0 => /lib64/libpthread.so.0 (0x00007f3665241000)
        libc.so.6 => /lib64/libc.so.6 (0x00007f3664e7c000)
        /lib64/ld-linux-x86-64.so.2 (0x00007f36657e3000)

Makefile Show resolved Hide resolved
test/exe/require_glibc.go Outdated Show resolved Hide resolved
test/exe/require_glibc.go Outdated Show resolved Hide resolved
Signed-off-by: Dhi Aurrahman <[email protected]>
Signed-off-by: Dhi Aurrahman <[email protected]>
@istio-testing
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dio, incfly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@istio-testing istio-testing merged commit 23a7564 into istio-ecosystem:master Apr 6, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants