Fix make compose #213
Closed
Fix make compose #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dhi Aurrahman <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dio The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
dio
commented
Mar 27, 2022
| constexpr uint16_t kHealthCheckServerPort = 10004; | ||
| constexpr uint16_t kHealthCheckServerPort = 9091; |
There was a problem hiding this comment.
I'm not sure regarding this, seems like we had the same health check port (with the main one? I kept getting the port-in-use error).
Signed-off-by: Dhi Aurrahman <[email protected]>
|
/assign @incfly |
|
I think once: are merged, I'll revise this a bit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure we can do
make compose, and optionally build the binary (also the image) ofauth_server(by feeding the--buildflag:COMPOSE_ARGS=--build make compose).Signed-off-by: Dhi Aurrahman [email protected]