Enable Dynamic Config Push #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
virajrk
force-pushed
the
dynamoDB
branch
2 times, most recently
from
16e3a1f to
c4738fc
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #379 +/- ##
==========================================
+ Coverage 77.22% 77.26% +0.03%
==========================================
Files 75 75
Lines 10420 10519 +99
==========================================
+ Hits 8047 8127 +80
- Misses 1958 1968 +10
- Partials 415 424 +9 ☔ View full report in Codecov by Sentry. |
virajrk
force-pushed
the
dynamoDB
branch
2 times, most recently
from
ffe28d8 to
14e2a5f
Compare
vinay-g
requested changes
Jan 27, 2025
There was a problem hiding this comment.
2 items
- I think we discussed having an interface so that OSS admiral will not have issues with Dynamo implementation
- I understand the call section where your NLB logic will be invoked is not done, but are we going with running the update only for changed clusters or all ?
admiral/pkg/clusters/dynamoDB.go
Outdated
| items, err := client.svc.Query(&dbQuery) | ||
|
|
||
| if err != nil { | ||
| return configData, fmt.Errorf("Failed to fetch dynamic config : %s", err) |
There was a problem hiding this comment.
can you make sure we have this is a format where we can easily search example task=DynamicConfigGet etc in the log
admiral/pkg/clusters/types.go
Outdated
| @@ -162,6 +164,12 @@ func NewRemoteRegistry(ctx context.Context, params common.AdmiralParams) *Remote | |||
| serviceEntrySuspender = NewDummyServiceEntrySuspender() | |||
| } | |||
|
|
|||
| if common.IsAdmiralDynamicConfigEnable() { | |||
There was a problem hiding this comment.
nit pick can we make is IsAdmiralDynamicConfigEnabled
| return false | ||
| } | ||
|
|
||
| if DynamicConfigCheckSum == sha256.Sum256([]byte(fmt.Sprintf("%v", config))) { |
There was a problem hiding this comment.
nit pick, we had checked m5s vs sha256 for speed and cpu, for a different requirement and chose md5 for being a little fast and consuming a little less CPU
$ openssl speed md5 sha256
The 'numbers' are in 1000s of bytes per second processed.
type 16 bytes 64 bytes 256 bytes 1024 bytes 8192 bytes 16384 bytes
md5 51896.59k 156143.77k 336557.91k 472481.13k 536428.54k 543648.43k
sha256 42111.47k 120368.74k 247776.17k 335801.69k 376607.34k 377296.21k
admiral/cmd/admiral/cmd/root.go
Outdated
Comment on lines
281
to
283
| rootCmd.PersistentFlags().StringVar(¶ms.NLBEnabledClusters, "nlb_enabled_clusters", "", "Comma seperated list of enabled clusters to be enabled for NLB") | ||
| rootCmd.PersistentFlags().StringVar(¶ms.NLBEnabledIdentityList, "nlb_enabled_identity_list", "", "Comma seperated list of enabled idenity list to be enabled for NLB") | ||
| rootCmd.PersistentFlags().StringVar(¶ms.CLBEnabledClusters, "clb_enabled_clusters", "", "Comma seperated list of enabled clusters to be enabled for CLB") |
There was a problem hiding this comment.
should this not be StringSliceVar ?
virajrk
force-pushed
the
dynamoDB
branch
2 times, most recently
from
15b99ac to
5fbda35
Compare
added 17 commits
January 29, 2025 15:25
Signed-off-by: Viraj Kulkarni <[email protected]>
Signed-off-by: Viraj Kulkarni <[email protected]>
Signed-off-by: Viraj Kulkarni <[email protected]>
Signed-off-by: Viraj Kulkarni <[email protected]>
Signed-off-by: Viraj Kulkarni <[email protected]>
Signed-off-by: Viraj Kulkarni <[email protected]>
Signed-off-by: Viraj Kulkarni <[email protected]>
Signed-off-by: Viraj Kulkarni <[email protected]>
Signed-off-by: Viraj Kulkarni <[email protected]>
Signed-off-by: Viraj Kulkarni <[email protected]>
Signed-off-by: Viraj Kulkarni <[email protected]>
Signed-off-by: Viraj Kulkarni <[email protected]>
Signed-off-by: Viraj Kulkarni <[email protected]>
Signed-off-by: Viraj Kulkarni <[email protected]>
Signed-off-by: Viraj Kulkarni <[email protected]>
Signed-off-by: Viraj Kulkarni <[email protected]>
Signed-off-by: Viraj Kulkarni <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
🚨 Please review this repository's contribution guidelines.
Description
Adding support for pushing dynamic config.
[Link to related ISSUE]
Thank you!