Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replaced allow list with exclusion list for vs based routing #378

Conversation

shriramsharma
Copy link
Collaborator

replaced allow list with exclusion list for vs based routing

Signed-off-by: Shriram Sharma <[email protected]>
Signed-off-by: Shriram Sharma <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 25.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 77.36%. Comparing base (8226882) to head (f78ec25).

Files with missing lines Patch % Lines
admiral/pkg/clusters/virtualservice_routing.go 0.00% 7 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #378      +/-   ##
==========================================
+ Coverage   77.22%   77.36%   +0.13%     
==========================================
  Files          75       75              
  Lines       10417    10423       +6     
==========================================
+ Hits         8045     8064      +19     
+ Misses       1963     1948      -15     
- Partials      409      411       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shriramsharma shriramsharma merged commit bff6695 into istio-ecosystem:master Jan 21, 2025
3 checks passed
@shriramsharma shriramsharma deleted the add-vs-routing-cluster-exclusion-param branch January 21, 2025 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants