log error, instead of returning when vs deletion fails #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirvanagit
requested review from
shriramsharma and
aattuluri
and removed request for
shriramsharma
aattuluri
requested changes
Aug 26, 2022
nirvanagit
force-pushed
the
vs-deletion
branch
3 times, most recently
from
3d22278 to
e1fbcde
Compare
added 2 commits
August 26, 2022 12:26
Signed-off-by: Anubhav Aeron <[email protected]>
Signed-off-by: Anubhav Aeron <[email protected]>
nirvanagit
force-pushed
the
vs-deletion
branch
from
e1fbcde to
2065e57
Compare
Signed-off-by: Anubhav Aeron <[email protected]>
done. |
itsLucario
pushed a commit
that referenced
this pull request
Nov 7, 2022
kpharasi
pushed a commit
that referenced
this pull request
Dec 19, 2024
* Inc code coverage for handler.go, util.go * Adding reset for admiral params * Catering to review comments * Cleaned up tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
When a replicated VS is deleted in the source cluster, it gets deleted in clusters where it is replicated in. During this process, if the deletion fails due to some reason, it skips deleting the vs from the remaining clusters.
This PR changes that behavior, and makes it consistent with deletion workflow for DestinationRules, and ServiceEntries, where it logs that there was an error and continues deleting the resource in other clusters.