Fix concurrent map access and remove unwanted code #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix concurrent map access. Remove unwanted code to create SEs based on user created destination rules
| @@ -48,7 +48,7 @@ func TestDeleteCacheControllerThatDoesntExist(t *testing.T) { | |||
|
|
|||
| w := RemoteRegistry{ | |||
| RemoteControllers: make(map[string]*RemoteController), | |||
| StartTime: time.Now(), | |||
| StartTime: time.Now(), | |||
There was a problem hiding this comment.
nitpick, formatting issues.
| @@ -62,7 +62,7 @@ func TestDeleteCacheController(t *testing.T) { | |||
|
|
|||
| w := RemoteRegistry{ | |||
| RemoteControllers: make(map[string]*RemoteController), | |||
| StartTime: time.Now(), | |||
| StartTime: time.Now(), | |||
There was a problem hiding this comment.
nitpick, formatting issues.
There was a problem hiding this comment.
Seems to be the right formatting now. Was messed up before.
shriramsharma
approved these changes
Jul 14, 2022
Codecov Report
@@ Coverage Diff @@
## master #245 +/- ##
==========================================
+ Coverage 72.78% 74.13% +1.34%
==========================================
Files 27 27
Lines 2657 2579 -78
==========================================
- Hits 1934 1912 -22
+ Misses 601 546 -55
+ Partials 122 121 -1
Continue to review full report at Codecov.
|
itsLucario
pushed a commit
to itsLucario/admiral
that referenced
this pull request
Aug 9, 2022
…cosystem#245) (istio-ecosystem#145) * Fix concurrent map access and remove unwanted code (istio-ecosystem#245) * MESH-1988 Co-authored-by: aattuluri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix concurrent map access on multiple controllers.
Remove unwanted code to create SEs based on user created destination rules.
Add
-raceto detect races in tests.