New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Routing policy addition #243

Merged

vinay-g merged 11 commits into istio-ecosystem:master from vinay-g:MESH-1656-routing-policy-addition

Aug 10, 2022

Collaborator

vinay-g commented Jul 8, 2022 •

edited

Loading

Rework from - #229

codecov-commenter commented Jul 8, 2022 •

edited

Loading

Codecov Report

Merging #243 (bf8c151) into master (f39083d) will decrease coverage by 0.45%.
The diff coverage is 68.24%.

@@            Coverage Diff             @@
##           master     #243      +/-   ##
==========================================
- Coverage   72.69%   72.24%   -0.46%     
==========================================
  Files          29       31       +2     
  Lines        2714     3066     +352     
==========================================
+ Hits         1973     2215     +242     
- Misses        617      705      +88     
- Partials      124      146      +22

Impacted Files	Coverage Δ
admiral/pkg/controller/common/config.go	`75.43% <0.00%> (-12.32%)`	⬇️
admiral/pkg/controller/common/common.go	`64.00% <24.13%> (-12.05%)`	⬇️
admiral/pkg/controller/common/types.go	`86.66% <42.85%> (-3.24%)`	⬇️
admiral/pkg/clusters/registry.go	`63.88% <43.33%> (-3.64%)`	⬇️
admiral/pkg/clusters/types.go	`58.21% <58.47%> (+0.28%)`	⬆️
admiral/pkg/controller/admiral/routingpolicy.go	`80.00% <80.00%> (ø)`
admiral/pkg/clusters/envoyfilter.go	`93.44% <93.44%> (ø)`
admiral/pkg/clusters/handler.go	`58.29% <100.00%> (ø)`
admiral/pkg/clusters/serviceentry.go	`80.72% <100.00%> (+0.16%)`	⬆️
admiral/pkg/clusters/util.go	`86.90% <100.00%> (+1.76%)`	⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

vinay-g requested review from shriramsharma and nirvanagit

July 12, 2022 14:49

vinay-g force-pushed the MESH-1656-routing-policy-addition branch from 6f9931a to cc4ca43 Compare

July 12, 2022 15:33

aattuluri changed the title ~~Mesh 1656 routing policy addition~~ Routing policy addition

shriramsharma reviewed

View reviewed changes

admiral/pkg/clusters/types.go Show resolved Hide resolved

shriramsharma reviewed

View reviewed changes

admiral/pkg/clusters/types.go Outdated Show resolved Hide resolved

shriramsharma reviewed

View reviewed changes

admiral/pkg/clusters/types.go Outdated Show resolved Hide resolved

shriramsharma reviewed

View reviewed changes

admiral/pkg/clusters/types.go Show resolved Hide resolved

shriramsharma reviewed

View reviewed changes

admiral/pkg/clusters/registry_test.go Outdated Show resolved Hide resolved

vinay-g force-pushed the MESH-1656-routing-policy-addition branch 3 times, most recently from f76e8c0 to b57f54f Compare

July 19, 2022 18:18

shriramsharma approved these changes

View reviewed changes

aattuluri previously requested changes

View reviewed changes

Contributor

aattuluri left a comment

Overall looks ok, but added some comments to refactor and/or changes

admiral/cmd/admiral/cmd/root.go Outdated Show resolved Hide resolved

admiral/cmd/admiral/cmd/root.go Show resolved Hide resolved

admiral/crd/routingPolicy.yaml Outdated Show resolved Hide resolved

admiral/pkg/clusters/envoyfilter.go Outdated Show resolved Hide resolved

admiral/pkg/controller/common/common.go Outdated Show resolved Hide resolved

install/sample/sample_rp.yaml Outdated Show resolved Hide resolved

vinay-g force-pushed the MESH-1656-routing-policy-addition branch from ac2c567 to d11bc66 Compare

August 1, 2022 17:05

psikka1 and others added 7 commits

August 2, 2022 18:06


          Adding the routing policy

97a0fb2

Signed-off-by: psikka1 <[email protected]>


          make sample routing policy more generic

6d1a286

Signed-off-by: psikka1 <[email protected]>


          address PR review

6e285b4

Signed-off-by: psikka1 <[email protected]>


          address some more comments

b5d5daf

Signed-off-by: psikka1 <[email protected]>


          add envoyfilter_test

b9aefaf

Signed-off-by: psikka1 <[email protected]>


          remove reference to qbo

Signed-off-by: psikka1 <[email protected]>


          Fomratting and log changes

3a03229

vinay-g force-pushed the MESH-1656-routing-policy-addition branch 7 times, most recently from 923138d to 904cd9c Compare

August 3, 2022 04:46


          Adding workload selector and tests

42e7b43

vinay-g force-pushed the MESH-1656-routing-policy-addition branch from 904cd9c to 42e7b43 Compare

August 3, 2022 05:10

vinay-g requested a review from aattuluri

August 3, 2022 05:17

istio-ecosystem deleted a comment from aattuluri


          Updating integration tests

bf8c151

nirvanagit reviewed

View reviewed changes

install/admiral/base/roles.yaml Outdated Show resolved Hide resolved

nirvanagit reviewed

View reviewed changes

admiral/pkg/controller/common/common.go Outdated Show resolved Hide resolved

nirvanagit reviewed

View reviewed changes

admiral/pkg/clusters/types.go Outdated Show resolved Hide resolved

nirvanagit reviewed

View reviewed changes

admiral/pkg/clusters/envoyfilter.go Show resolved Hide resolved


          Updating indentation

906e109

vinay-g dismissed aattuluri’s stale review

August 9, 2022 21:28

reviewed and looks good

vinay-g force-pushed the MESH-1656-routing-policy-addition branch from c416ae1 to 7352c9c Compare

August 9, 2022 22:28


          Updating routing policy enable to false

9df2135

vinay-g force-pushed the MESH-1656-routing-policy-addition branch from 7352c9c to 9df2135 Compare

August 10, 2022 01:51

vinay-g merged commit 306ab32 into istio-ecosystem:master

itsLucario pushed a commit that referenced this pull request


          Routing policy addition (#243) (#150)

4378d0a

* Adding the routing policy

Co-authored-by: psikka1 <[email protected]>
Co-authored-by: vgonuguntla <[email protected]>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet