Optimize GlobalTrafficPolicy fetching and endpoint generation time #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: aattuluri <[email protected]>
Signed-off-by: aattuluri <[email protected]>
Signed-off-by: aattuluri <[email protected]>
Signed-off-by: aattuluri <[email protected]>
This reverts commit a9fa409.
…mmit sha if neither i) or ii)
asushanthk
reviewed
May 2, 2022
| @@ -219,6 +233,35 @@ func modifyServiceEntryForNewServiceOrPod(event admiral.EventType, env string, s | |||
| return serviceEntries | |||
| } | |||
|
|
|||
| func updateGlobalGtpCache(cache *AdmiralCache, identity, env string, gtps map[string][]*v1.GlobalTrafficPolicy) { | |||
There was a problem hiding this comment.
Please add comments for this method
asushanthk
approved these changes
May 2, 2022
nirvanagit
reviewed
May 2, 2022
nirvanagit
reviewed
May 2, 2022
nirvanagit
reviewed
May 2, 2022
| @@ -1331,6 +1335,82 @@ func TestUpdateEndpointsForWeightedServices(t *testing.T) { | |||
|
|
|||
| } | |||
|
|
|||
| func TestUpdateGlobalGtpCache(t *testing.T) { | |||
|
|
|||
| admiralCache := &AdmiralCache{GlobalTrafficCache: &globalTrafficCache{identityCache: make(map[string]*v13.GlobalTrafficPolicy), mutex: &sync.Mutex{}}} | |||
There was a problem hiding this comment.
Can all the variable declaration and definition be added under a
var (
)
block.
nirvanagit
reviewed
May 2, 2022
| t.Run(c.name, func(t *testing.T) { | ||
| updateGlobalGtpCache(admiralCache, c.identity, c.env, c.gtps) | ||
| gtp := admiralCache.GlobalTrafficCache.GetFromIdentity(c.identity, c.env) | ||
| if c.expectedGtp == nil && gtp == nil { |
There was a problem hiding this comment.
May be use a single condition to condense all conditions.
if !reflect.DeepEqual(c.expectedGtp, gtp) {
t.Errorf("want: %v, got: %v")
}
nirvanagit
reviewed
May 2, 2022
| t.Errorf("%v", err) | ||
| func TestGlobalTrafficController_Updated(t *testing.T) { | ||
|
|
||
| gth := test.MockGlobalTrafficHandler{} |
There was a problem hiding this comment.
Nitpick: Can all the variable definition/declaration be added inside
var (
)
block.
There was a problem hiding this comment.
Similar comment for TestGlobalTrafficController_Added and TestGlobalTrafficController_Deleted
nirvanagit
reviewed
May 2, 2022
| gtpController.Updated(c.gtp, gtp) | ||
| gtpKey := common.GetGtpKey(c.gtp) | ||
| matchedGtps := gtpController.Cache.Get(gtpKey, c.gtp.Namespace) | ||
| if len(matchedGtps) != len(c.expectedGtps) { |
There was a problem hiding this comment.
Can we use !reflect.DeepEqual here ?
There was a problem hiding this comment.
Similar comment for TestGlobalTrafficController_Added and TestGlobalTrafficController_Deleted
nirvanagit
approved these changes
May 2, 2022
psikka1
pushed a commit
to psikka1/admiral
that referenced
this pull request
Jun 14, 2022
psikka1
pushed a commit
to psikka1/admiral
that referenced
this pull request
Jun 15, 2022
…stio-ecosystem#206) Signed-off-by: psikka1 <[email protected]>
asushanthk
pushed a commit
that referenced
this pull request
Jul 21, 2022
) Signed-off-by: sa <[email protected]>
itsLucario
pushed a commit
to itsLucario/admiral
that referenced
this pull request
Aug 9, 2022
* Tune default outlier detection parameters for remote endpoints (istio-ecosystem#207) * [bug] prevent panic when finding out rollout strategy (istio-ecosystem#210) * prevent panic when finding out rollout strategy Co-authored-by: Anubhav Aeron <[email protected]> * Optimize GlobalTrafficPolicy fetching and endpoint generation time (istio-ecosystem#206) Co-authored-by: aattuluri <[email protected]> Co-authored-by: Anubhav <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current approach
Deployment/Rollout event
Step 1: Collect all GTPs from all clusters matching this deployment and save them to cache
Step 2: Iterate over all cluster caches to group deployments and generate endpoints with matching GTPs
Step 3: Write to local clusters
Step 4: Write to remote clusters
New approach (in this PR)
GTP cache is managed in the controller itself by identity+env cache key
Deployment/Rollout event
Step 1: Collect GTPs (write matched GTP to global cache for APIs etc.) from only clusters where Deployment/Rollout instances are running
Step 2: Generate mesh endpoints from what is collected in Step 1
Step 3: Write to local clusters
Step 4: Write to remote clusters