-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: one to multiple source maps #21 #62
WIP: one to multiple source maps #21 #62
Conversation
👋 hey @DracoBlue, I apologize for not having had much time to look at this project lately. I'm excited that your'e looking into this. |
@DracoBlue still something you'd like to land, looks like a few tests are failing. |
@bcoe Yup. The test are failing because of the result dump. I am currently trying to get it working with a big webpack-based project. if this works properly I will add tests for my usecase and update the PR here. |
…ature/21-one-to-multiple-source-maps
@DracoBlue very much appreciated 👏 we just landed some source-map related functionality in Node.js core, that's made me excited about dusting off these libraries ... they now work for edge-cases like |
Nice! I am currently struggling with those member variables. Hopefully I get this sorted within next days. Having v8 istanbul reporting for production sourcemap files would help me to end2end test our production build with little effort ;). |
@DracoBlue what is the progress with this? I struggling with the same issue. |
I've added these changes to my project and when trying to generate the report it's failing:
|
I am still struggling with the code, since some of these member variables are used elsewhere and it is not easy to emulate. My ncc build does not highlight properly at all. So long I close this PR until I have time for this matter again. |
Will try to complete this |
I am trying to fix #21 and
v8-to-istanbul: source-mappings from one to many files not yet supported
Approach: