[FE] 디자인 시스템 세팅 #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 로고 컴포넌트, GlobalStyle, designSystem 생성 - icon svg 파일 업로드 - Pretendard font
Kakamotobi
reviewed
Jul 24, 2023
fe/src/App.tsx
Outdated
Comment on lines
3
to
4
| import GlobalStyle from "styles/GlobalStyle"; | ||
| import designSystem from "styles/designSystem"; |
There was a problem hiding this comment.
@components처럼 src/에 있는 최상단 폴더들을 path alias로 등록하면 좋을것 같아요.
fe/src/styles/designSystem.ts
Outdated
| @@ -0,0 +1,53 @@ | |||
| const designSystem = { | |||
There was a problem hiding this comment.
단 한가지를 export default할 때, 이렇게 const로 declare를 안하고 바로 export default { colors: { ... }, ... } 이런식으로 하는 것은 어떤가요? 어차피 파일 이름이 충분히 무엇인지 나타내는 것 같아요.
There was a problem hiding this comment.
그리고 위에 GlobalStyle도 동일하게 할 수 있을거 같아요.
- design modules 불필요한 변수 선언 없이 export default - src 최상단 디렉터리 path alias 선언
youzysu
force-pushed
the
fe/design/#7-design-system
branch
from
92e2d65
to
37707d1
Compare
youzysu
added a commit
that referenced
this pull request
Jul 25, 2023
* #7 design: 디자인 시스템 세팅 (#8) * #7 design: 디자인 시스템 세팅 - 로고 컴포넌트, GlobalStyle, designSystem 생성 - icon svg 파일 업로드 - Pretendard font * #7 refactor: 로고 컴포넌트 props 구조 수정 * #7 refactor: 디자인 시스템 세팅 리뷰 반영 - design modules 불필요한 변수 선언 없이 export default - src 최상단 디렉터리 path alias 선언 * #7 design: light/dark 모드 design system 세팅 --------- Co-authored-by: 유지수 Jisoo Yoo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
What is this PR? 👓
To reviewers 👋