Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FE] Button Component 리팩토링 #36

Merged
merged 1 commit into from
Jul 28, 2023
Merged

[FE] Button Component 리팩토링 #36

merged 1 commit into from
Jul 28, 2023

Conversation

youzysu
Copy link
Member

@youzysu youzysu commented Jul 28, 2023 •
edited
Loading

Issues

What is this PR? 👓

  • Button Component 모듈 통합
  • Button Type 별로 Styled-component 하위에 정의
  • 불필요한 styled props $variant 전달 삭제

To reviewers 👋

  • 사용시 헷갈릴 것 같아서(이미 카카모토비가 헷갈리셔서 🤣) 모듈 분리하지 않고 variant 별 StyledButton을 하위에 선언했어요!
  • 변경된 방식으로 수정하여 적용했어요.

@youzysu
issue-tracker-08#10 refactor: Button Component Styled 모듈 통합
0b625eb 
- Button Type 별로 Styled-component 하위에 정의
- 불필요한 styled props $variant 전달 삭제
@youzysu youzysu added this to the [FE] Sprint #01 milestone Jul 28, 2023
@youzysu youzysu self-assigned this Jul 28, 2023
@youzysu youzysu merged commit e21aad9 into issue-tracker-08:fe-w1 Jul 28, 2023
23Yong pushed a commit that referenced this pull request Aug 7, 2023
@hongbiii
Merge pull request #36 from issue-tracker-08/fe-week2
ed3a3bd 
[team#08 - FE] 2주차 PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@youzysu youzysu

Labels
front-end
Projects
None yet
Milestone
[FE] Sprint #01
Development

Successfully merging this pull request may close these issues.
1 participant
@youzysu