Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#10 fix: Button Component Styled-component Warning 해결 #22

Merged
merged 1 commit into from
Jul 26, 2023
Merged

#10 fix: Button Component Styled-component Warning 해결 #22

merged 1 commit into from
Jul 26, 2023

Conversation

youzysu
Copy link
Member

@youzysu youzysu commented Jul 26, 2023 •
edited
Loading

Issues

What is this PR? 👓

  • variant transient props로 수정

Key changes 🔑

image

To reviewers 👋

  • console에 styled-component Warning이 있어서 variant를 transient props($variant)가 되도록 수정하여 해결했어요.
  • console warning 사라진 것 확인해서 이상 없으면 바로 merge 부탁드려요 🙏

@youzysu youzysu added this to the [FE] Sprint #01 milestone Jul 26, 2023
@youzysu youzysu requested a review from Kakamotobi July 26, 2023 09:15
@youzysu youzysu self-assigned this Jul 26, 2023
@Kakamotobi Kakamotobi merged commit fb2cca6 into issue-tracker-08:fe-w1 Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kakamotobi Kakamotobi Kakamotobi approved these changes

Assignees

@youzysu youzysu

Labels
front-end
Projects
None yet
Milestone
[FE] Sprint #01
Development

Successfully merging this pull request may close these issues.
2 participants
@youzysu @Kakamotobi