Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BE] fix: 이슈 목록 조회 필터 수정 #159

Merged
merged 3 commits into from
Aug 17, 2023
Merged

[BE] fix: 이슈 목록 조회 필터 수정 #159

merged 3 commits into from
Aug 17, 2023

Conversation

tjdqls1200
Copy link
Collaborator

What is this PR? 👓

Key changes 🔑

  • 페이징 조회시 결과가 잘려서(이슈 목록 10개가 보여야 하는데 5개가 조회되는) 나오는 문제 발생
  • LEFT JOIN으로 결과가 증가해서 LIMIT로 자를 수 없음
  • DENSE_RANK()를 사용해서 해결
  • 이슈 상태 (status: open, close)를 (state: open, closed)로 변경

To reviewers 👋

  • 쿼리가 크다보니 테스트 코드 작성이나 직접 테스트 해보기가 어려운 것 같습니다..!
  • 더 효율적인 방법이 생각나시면 말씀해주세요!

@tjdqls1200
fix: 이슈 목록 조회 필터 수정
93fa159 
- LEFT JOIN으로 페이징 결과가 증가해서 LIMIT로 자를 수 없음
- DENSE_RANK()를 사용해서 해결
- 이슈 상태 status, open, close를 state, open, closed로 변경
@tjdqls1200 tjdqls1200 added bug Something isn't working back-end labels Aug 17, 2023
@tjdqls1200 tjdqls1200 added this to the [BE] Sprint #4 milestone Aug 17, 2023
@HyowonSin HyowonSin changed the title fix: 이슈 목록 조회 필터 수정 [BE] fix: 이슈 목록 조회 필터 수정 Aug 17, 2023
@HyowonSin HyowonSin linked an issue Aug 17, 2023 that may be closed by this pull request
[BE] 이슈 목록 페이징 버그 수정 #158
Closed
2 tasks
23Yong
23Yong approved these changes Aug 17, 2023
View reviewed changes
Copy link

@23Yong 23Yong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!
DENSE_RANK() 키워드와 closed 컨벤션 통일까지 👍

@tjdqls1200 tjdqls1200 merged commit 71fb2fe into be-w4 Aug 17, 2023
1 check passed
@tjdqls1200 tjdqls1200 deleted the be/fix/issue-search branch August 17, 2023 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@23Yong 23Yong 23Yong approved these changes

@pie2457 pie2457 Awaiting requested review from pie2457

Assignees

@HyowonSin HyowonSin

@tjdqls1200 tjdqls1200

Labels
back-end bug Something isn't working
Projects
None yet
Milestone
[BE] Sprint #4
Development

Successfully merging this pull request may close these issues.

[BE] 이슈 목록 페이징 버그 수정
3 participants
@tjdqls1200 @23Yong @HyowonSin