Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update check logic #93

Merged
merged 3 commits into from
Oct 31, 2024
Merged

Update check logic #93

merged 3 commits into from
Oct 31, 2024

Conversation

ncalteen
Copy link
Contributor

Updates the logic used to check if a version exists so that a comment is added or updated in PRs whenever the version passes or fails the check.

@ncalteen ncalteen self-assigned this Oct 31, 2024
@ncalteen ncalteen requested a review from a team as a code owner October 31, 2024 18:17
Copy link

github-actions bot commented Oct 31, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 5 0 0.09s
✅ JSON jsonlint 9 0 0.39s
✅ JSON prettier 9 0 1.81s
✅ JSON v8r 9 0 37.27s
✅ MARKDOWN markdownlint 1 0 0.67s
✅ MARKDOWN markdown-link-check 1 0 3.64s
✅ REPOSITORY checkov yes no 14.01s
✅ REPOSITORY gitleaks yes no 0.63s
✅ REPOSITORY git_diff yes no 0.06s
✅ REPOSITORY grype yes no 14.5s
✅ REPOSITORY secretlint yes no 1.22s
✅ REPOSITORY trivy yes no 10.28s
✅ REPOSITORY trivy-sbom yes no 0.89s
✅ REPOSITORY trufflehog yes no 16.2s
✅ TYPESCRIPT eslint 14 0 5.87s
✅ TYPESCRIPT prettier 14 0 1.49s
✅ XML xmllint 2 0 0.0s
✅ YAML prettier 20 0 0.65s
✅ YAML v8r 20 0 38.79s
✅ YAML yamllint 20 0 0.39s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@ncalteen ncalteen requested a review from Copilot October 31, 2024 18:20

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 9 out of 13 changed files in this pull request and generated no suggestions.

Files not reviewed (4)
  • .vscode/settings.json: Language not supported
  • package.json: Language not supported
  • fixtures/octokit.ts: Evaluated as low risk
  • src/version.ts: Evaluated as low risk
Comments skipped due to low confidence (5)

tests/messages.test.ts:61

  • The test case should verify the content of the comment being updated.
expect(mocktokit.rest.issues.updateComment).toHaveBeenCalled()

tests/messages.test.ts:77

  • The test case should verify the content of the comment being updated.
expect(mocktokit.rest.issues.updateComment).toHaveBeenCalled()

tests/messages.test.ts:88

  • The test case should verify the content of the comment being created.
expect(mocktokit.rest.issues.createComment).toHaveBeenCalled()

tests/messages.test.ts:99

  • The test case should verify the content of the comment being created.
expect(mocktokit.rest.issues.createComment).toHaveBeenCalled()

src/messages.ts:13

  • The identifier string uses '${{ github.workflow }}', which might not be correctly interpolated. Consider using a different method to ensure the identifier is unique and correctly formatted.
const identifier = '<!-- senver: workflow=${{ github.workflow }} -->'

Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more

@ncalteen ncalteen requested a review from Copilot October 31, 2024 18:24
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 9 out of 13 changed files in this pull request and generated 2 suggestions.

Files not reviewed (4)
  • .vscode/settings.json: Language not supported
  • package.json: Language not supported
  • fixtures/octokit.ts: Evaluated as low risk
  • src/version.ts: Evaluated as low risk

Tip: Leave feedback on Copilot's review comments with the 👎 and 👍 buttons to help improve review quality. Learn more

src/messages.ts Outdated Show resolved Hide resolved
src/main.ts Show resolved Hide resolved
@ncalteen ncalteen requested a review from Copilot October 31, 2024 18:29

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again, by re-requesting a review.

@ncalteen ncalteen merged commit df8a60d into main Oct 31, 2024
5 checks passed
@ncalteen ncalteen deleted the ncalteen/check branch October 31, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant