-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update check logic #93
Conversation
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 9 out of 13 changed files in this pull request and generated no suggestions.
Files not reviewed (4)
- .vscode/settings.json: Language not supported
- package.json: Language not supported
- fixtures/octokit.ts: Evaluated as low risk
- src/version.ts: Evaluated as low risk
Comments skipped due to low confidence (5)
tests/messages.test.ts:61
- The test case should verify the content of the comment being updated.
expect(mocktokit.rest.issues.updateComment).toHaveBeenCalled()
tests/messages.test.ts:77
- The test case should verify the content of the comment being updated.
expect(mocktokit.rest.issues.updateComment).toHaveBeenCalled()
tests/messages.test.ts:88
- The test case should verify the content of the comment being created.
expect(mocktokit.rest.issues.createComment).toHaveBeenCalled()
tests/messages.test.ts:99
- The test case should verify the content of the comment being created.
expect(mocktokit.rest.issues.createComment).toHaveBeenCalled()
src/messages.ts:13
- The identifier string uses '${{ github.workflow }}', which might not be correctly interpolated. Consider using a different method to ensure the identifier is unique and correctly formatted.
const identifier = '<!-- senver: workflow=${{ github.workflow }} -->'
Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 9 out of 13 changed files in this pull request and generated 2 suggestions.
Files not reviewed (4)
- .vscode/settings.json: Language not supported
- package.json: Language not supported
- fixtures/octokit.ts: Evaluated as low risk
- src/version.ts: Evaluated as low risk
Tip: Leave feedback on Copilot's review comments with the 👎 and 👍 buttons to help improve review quality. Learn more
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again, by re-requesting a review.
Updates the logic used to check if a version exists so that a comment is added or updated in PRs whenever the version passes or fails the check.