Skip to content

Commit

Permalink
fix: prevent eslint errors from blocking build (#506)
Browse files Browse the repository at this point in the history
Currently, when we attempt to start our react app, create-react-app
fails to compile when there are any eslint or prettier errors. The
reason for this is documented in this github issue: facebook/create-react-app#9887 (comment)

This issue is fixed with react-scripts v4.0.2 with the use of an
ESLINT_NO_DEV_ERRORS env var (this is documented under advanced
configuration here: https://create-react-app.dev/docs/advanced-configuration/)

This commit adds the ESLINT_NO_DEV_ERRORS env var to our env-example
file. We will need to separately add it to our production and staging
environments too.
  • Loading branch information
kwajiehao authored Jun 7, 2021
1 parent 9df3943 commit 16ee279
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions .env-example
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ export REACT_APP_BACKEND_URL=''
export REACT_APP_SENTRY_ENV=''
export REACT_APP_SENTRY_DSN=''
export REACT_APP_ENV='LOCAL_DEV'
export ESLINT_NO_DEV_ERRORS=true

# Cypress test environment variables
export CYPRESS_BASEURL=''
Expand Down

0 comments on commit 16ee279

Please sign in to comment.