no_babel_transform option & change entrypoint iso overloads to return void #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbalicki2
reviewed
Dec 21, 2024
| None, | ||
| format!( | ||
| " | ||
| export function iso<T>( |
rbalicki2
reviewed
Dec 21, 2024
There was a problem hiding this comment.
This makes me think that we should not be using error|ignore|warning for this, but instead have a "no_babel_transform": bool option or something. Thoughts?
Anyway, happy to land this as is to unblock Randall, but if you're up for making ☝️ change, we can skip a step
|
Makes sense, I can make this change |
rbalicki2
requested changes
Dec 26, 2024
| on_missing_babel_transform: create_optional_validation_level( | ||
| options.on_missing_babel_transform, | ||
| ), | ||
| no_babel_transform: options.no_babel_transform, |
There was a problem hiding this comment.
Let's rebase this on main and regenerate the schema as well
| " console.warn('iso: Unexpected invocation at runtime. Either the Babel transform ' + | ||
| 'was not set up, or it failed to identify this call site. Make sure it ' + | ||
| 'is being used verbatim as `iso`.'); | ||
| return (clientFieldResolver: any) => clientFieldResolver;" |
There was a problem hiding this comment.
can we modify this error message too? E.g. add "If you cannot use the babel transform, set options.no_babel_transform to true in your Isograph config."
PatrykWalach
force-pushed
the
skip-iso-entrypoint-overloads-on-missing-babel-transform
branch
from
c30a130 to
ecd3fe2
Compare
…m' of github.com:PatrykWalach/isograph into skip-iso-entrypoint-overloads-on-missing-babel-transform
rbalicki2
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.