cache rust build with turbo
#261
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These are in parallel so I've added |
rbalicki2
requested changes
Dec 26, 2024
| path: .turbo | ||
| key: ${{ runner.os }}-turbo-${{ inputs.artifact-name }}-${{ github.sha }} | ||
| restore-keys: | | ||
| ${{ runner.os }}-turbo-${{ inputs.artifact-name }}- |
There was a problem hiding this comment.
TBH I don't really understand what's happening here, so apologies for the basic question, but should we have ${{ inputs.artifact-name }}-${{ github.sha }} or the like here?
There was a problem hiding this comment.
This restores .turbo directory that contains all the hashed inputs and outputs.
The actions/cache will lookup key first, then if it's not available it will look for entry starting with the patterns provided in restore-keys.
So this let's us restore cache from previous commit.
turbo.json
Outdated
| "$schema": "https://turbo.build/schema.json", | ||
| "tasks": { | ||
| "//#build": { | ||
| "inputs": ["crates/**", "Cargo.*"], |
There was a problem hiding this comment.
Perhaps we should add relay-crates/** as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19