Cache tsc with turbo #258
Open
Cache tsc with turbo #258
+114
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So I need to figure out if using cache multiple times is merging the results or overriding them 🤔 - name: Cache turbo
uses: actions/cache@v4
with:
path: .turbo
key: ${{ runner.os }}-turbo-${{ github.sha }}
restore-keys: |
${{ runner.os }}-turbo- |
|
Ok, these jobs are sequential so there are no overrides |
rbalicki2
approved these changes
Dec 28, 2024
| "$schema": "https://turbo.build/schema.json", | ||
| "tasks": { | ||
| "compile": { | ||
| "dependsOn": ["^compile"], |
There was a problem hiding this comment.
is this right? Does this mean that we're going to require the Rust compiler to be built before we build the JS?
There was a problem hiding this comment.
The arrow ^ has the same meaning as pnpm -r - dependencies of each package need to be compiled first
| { | ||
| "$schema": "https://turbo.build/schema.json", | ||
| "tasks": { | ||
| "compile": { |
There was a problem hiding this comment.
can we name this something like compileTypescript or something?
(Perhaps we should also rename the other ones to indicate that they refer to the Rust side)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.