process client pointer #254
Open
+416
−80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbalicki2
requested changes
Nov 12, 2024
| if let Some(directive) = | ||
| find_directive_named(&scalar_field_selection.directives, *LOADABLE_DIRECTIVE_NAME) | ||
| { | ||
| &|scalar_pointer_selection| { |
There was a problem hiding this comment.
Hm... I think of a pointer as always a linked selection or pointing to an object, and scalar always being a field. The things that I think could work here (and below) are: scalar_selection, scalar_field_selection, and linked_selection, linked_pointer_selection, object_pointer_selection, object_selection
I think scalar_field_selection and object_pointer_selection are the clearest. Wdyt?
rbalicki2
reviewed
Nov 12, 2024
rbalicki2
force-pushed
the
process-client-pointer
branch
from
c910e4f to
941d72a
Compare
rbalicki2
requested changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.