Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed "path too long" error on windows ci workflow target #21

Merged
merged 1 commit into from
Feb 17, 2024

Conversation

adrtivv
Copy link
Contributor

@adrtivv adrtivv commented Feb 15, 2024

Resolves issue #10

Checked the relay's ci workflow config, didn't find a similar solution, they're probably using some other way to implement the same fix.

Cargo internally uses libgit2 for git related workflows, and the library has open issues regarding this that haven't been fixed yet.

More info can be found here:- rust-lang/cargo#13020

TL;DR:- Windows sucks, but made it work.

@rbalicki2
Copy link
Collaborator

Love it!! Thank you! I'll review and merge tomorrow. Thank you so much for doing this. This will be part of the 0.1.1 release!

Copy link
Collaborator

@rbalicki2 rbalicki2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!! Let's just use a separate field here (i.e. longpaths: true) instead of special casing it, and then let's get this landed.

Thank you so much for enabling Windows!!!

.github/workflows/ci.yml Show resolved Hide resolved
@rbalicki2
Copy link
Collaborator

🎉 Love it, thank you!!

@rbalicki2 rbalicki2 merged commit 426b328 into isographlabs:main Feb 17, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants