don't use stale itemCleanupPairRef

isographlabs · Jan 3, 2025 · ef89d4d · ef89d4d
1 parent 5bc585f
commit ef89d4d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 8 deletions.
diff --git a/libs/isograph-react-disposable-state/src/useDisposableState.ts b/libs/isograph-react-disposable-state/src/useDisposableState.ts
@@ -54,11 +54,11 @@ export function useDisposableState<T = never>(
         return;
       }
       lastCommittedParentCache.current = parentCache;
-      // capture last set pair in a variable
-      const current = itemCleanupPairRef.current;
+
       return () => {
-        // current is a stale variable
-        current?.[1]();
+        if (itemCleanupPairRef.current !== null) {
+          itemCleanupPairRef.current[1]();
+        }
       };
     },
     [parentCache],

diff --git a/libs/isograph-react-disposable-state/src/useLazyDisposableState.ts b/libs/isograph-react-disposable-state/src/useLazyDisposableState.ts
@@ -36,11 +36,9 @@ export function useLazyDisposableState<T>(
       return;
     }
     lastCommittedParentCache.current = parentCache;
-    // capture last set pair in a variable
-    const current = itemCleanupPairRef.current;
+
     return () => {
-      // current is a stale variable
-      const cleanupFn = current?.[1];
+      const cleanupFn = itemCleanupPairRef.current?.[1];
       // TODO confirm useEffect is called in order.
       if (cleanupFn == null) {
         throw new Error(