Skip to content
This repository has been archived by the owner on Aug 18, 2020. It is now read-only.

Add API-X to vagrant install; Resolves https://github.com/Islandora-C… #3

Merged
merged 7 commits into from
Feb 3, 2017

Conversation

ruebot
Copy link
Contributor

@ruebot ruebot commented Jan 24, 2017

…LAW/CLAW/issues/504

See: Islandora/documentation#504

How to test:

  • clone repo, and checkout issue-504 branch
  • vagrant up
  • You should have no errors in the build, and see something along the lines of:
==> default: Installing API-X
==> default: Installing API-X
==> default: 337 [sshd-SshClient[7382f612]-nio2-thread-2] WARN org.apache.sshd.client.keyverifier.AcceptAllServerKeyVerifier - Server at /0.0.0.0:8101 presented unverified RSA key: 6a:cc:33:3d:76:08:39:0a:34:1c:00:20:c2:d1:5a:1d
==> default: Adding feature url mvn:org.fcrepo.apix/fcrepo-api-x-karaf/0.1.0/xml/features
==> default: 
==> default: 
==> default: Running provisioner: shell...
    default: Running: /tmp/vagrant-shell20170126-11798-3ueq4q.sh

@dannylamb @whikloj can you test?

@dannylamb
Copy link
Contributor

@ruebot I think we need to update fcrepo-camel. Which will require updating camel to 2.18.x. This will also force us to upgrade the amherst services we have running as well.

That's an oversight on my part.

@dannylamb
Copy link
Contributor

@ruebot Are you ok with handling that explosion of scope? We can address all those individually if you don't have the time right now.

@ruebot
Copy link
Contributor Author

ruebot commented Jan 24, 2017

@dannylamb no worries. I can make it happen!

@ruebot
Copy link
Contributor Author

ruebot commented Jan 24, 2017

@dannylamb I haven't touched the Camel side of things in the build in a while. Am I missing something, I don't see where we actually install Camel. And, it looks like the CAMEL_VERSION variable actually does nothing now. I'm not seeing anything obvious camel-wise in scripts/karaf.sh, scripts/fcrepo-camel-toolbox.sh, or scripts/islandora-karaf-components.sh.

@dannylamb
Copy link
Contributor

@ruebot https://github.com/Islandora-CLAW/claw_vagrant/blob/master/configs/karaf/fcrepo_camel_toolbox.script#L1

It's a transitive dependency of fcrepo-camel-toolbox. Try bumping the version to 4.7.0.

You can update Amherst stuff here: https://github.com/Islandora-CLAW/claw_vagrant/blob/master/configs/karaf/islandora_id_mapping_service.script#L1

@ruebot
Copy link
Contributor Author

ruebot commented Jan 25, 2017

@dannylamb ready for even more scope creep? Looks like we'll need to update Alpaca to make this happen. I believe we need to align it with the versions listed in the fcrepo-camel-toolbox 4.7.0 release notes. This is what I think I need to update in order to proceed:

@acoburn that sound about right, or am I missing anything?

@dannylamb ...also, let me know if you want me to create a separate issue for the above, or just continue the work on Alpaca with this issue number.

@dannylamb
Copy link
Contributor

dannylamb commented Jan 25, 2017

@ruebot That sounds like a good course of action. Carry on. Just be sure to link both pulls in the issue.

@ruebot
Copy link
Contributor Author

ruebot commented Jan 27, 2017

@dannylamb @whikloj ready for review at you convenience.

...I updated my initial comment too with instructions.

@dannylamb
Copy link
Contributor

@ruebot changes are looking good. I'll spin up a copy as soon as I can and test.

Copy link
Contributor

@dannylamb dannylamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something came up when working on Islandora/Alpaca#28. The vagrant environment needs to be able to resolve Drupal urls, which we can't do at the moment because of our port forwarding strategy. Can you please run apache on port 8000 so that localhost:8000 resolves on both guest and host machine?

feature:repo-add mvn:org.fcrepo.camel/toolbox-features/4.6.2/xml/features
feature:repo-add camel 2.18.1
feature:repo-add activemq 5.14.0
feature:repo-add mvn:org.fcrepo.camel/toolbox-features/4.7.0/xml/features
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we install Alpaca first, we don't need these feature declarations. Alpaca's features.xml will take care of it for us and you can delete these three lines.

@@ -1,4 +1,4 @@
feature:repo-add mvn:edu.amherst.acdc/acrepo-karaf/1.0.6/xml/features
feature:repo-add mvn:edu.amherst.acdc/acrepo-karaf/1.0.8/xml/features
feature:install acrepo-services-activemq
Copy link
Contributor

@dannylamb dannylamb Feb 1, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been replaced with fcrepo-service-activemq. If this script gets run after alpaca.sh, we'll be fine to delete this.

@dannylamb
Copy link
Contributor

vagrant up

@@ -18,4 +18,4 @@ FITS_WS_VERSION=1.1.3
MYSQL_USER=root
MYSQL_PASS=islandora
MYSQL_CONNECTOR_VERSION=6.0.4
GITHUB_TOKEN=changeme
GITHUB_TOKEN=f71459f666cabb3588d019b4d11e54e0befbda72
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ruebot are you giving your token away here?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants