-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(samgongustofa): increase timeout in API connection #17238
base: main
Are you sure you want to change the base?
Conversation
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Datadog ReportAll test runs ✅ 4 Total Test Services: 0 Failed, 4 Passed Test Services
|
What
We're seeing some timeout errors in datadog related to these clients, testing to see if increasing the timeout will fix that
Also fixing the method to calculate the prune date to ensure it is before midnight in UTC.
Previously, the prune date was determined as follows:
const pruneDate = new Date(date.toUTCString())
pruneDate.setHours(23, 59, 59)
However, while toUTCString() converts the date to a string in UTC, creating a Date object from it does not enforce UTC context. JavaScript Date objects default to the local timezone when setting fields like hours, meaning that setHours manipulates the time in the local timezone. This can cause inconsistencies if the system's timezone is not UTC.
Checklist: