feat(island-ui): add typography from figma tokens #17131

disaerna · 2024-12-04T14:49:10Z

...

Attach a link to issue if relevant

What

Specify what you're trying to achieve

Why

Specify why you need to achieve this

Screenshots / Gifs

Attach Screenshots / Gifs to help reviewers understand the scope of the pull request

Checklist:

I have performed a self-review of my own code
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
Formatting passes locally with my changes
I have rebased against main before asking for a review

coderabbitai · 2024-12-04T14:49:18Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2024-12-04T14:59:40Z

Deployed services: application-system-api,application-system-form,service-portal,portals-admin,consultation-portal,api,web,skilavottord-web,island-ui-storybook,download-service,air-discount-scheme-web,regulations-admin-backend,application-system-api-worker,services-bff-portals-admin,services-bff-portals-my-pages.
Excluded services: contentful-apps

datadog-island-is · 2024-12-04T15:03:10Z

Datadog Report

All test runs b87e717 🔗

✅ 34 Total Test Services: 0 Failed, 31 Passed
🔻 Test Sessions change in coverage: 1 decreased (-0.01%), 8 increased, 149 no change

Test Services

This report shows up to 10 services

Service Name	Passed	Total Time	Code Coverage Change	Test Service View
`air-discount-scheme-web`	2	6.49s	1 no change	Link
`api`	4	2.46s	1 no change	Link
`application-api-files`	2	4.34s	1 no change	Link
`application-core`	97	15.36s	1 no change	Link
`application-system-api`	46	2m 16.82s	1 no change	Link
`application-template-api-modules`	118	2m 7.74s	1 decreased (-0.01%)	Link
`application-templates-accident-notification`	148	15.05s	1 no change	Link
`application-templates-criminal-record`	2	9.69s	1 no change	Link
`application-templates-driving-license`	13	13.46s	1 no change	Link
`application-templates-example-payment`	2	10.26s	1 no change	Link

🔻 Code Coverage Decreases vs Default Branch (1)

application-template-api-modules - jest 30.2% (-0.01%) - Details

codecov · 2024-12-04T15:12:04Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.62%. Comparing base (3719969) to head (fde1ac1).

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #17131      +/-   ##
==========================================
- Coverage   35.75%   35.62%   -0.14%     
==========================================
  Files        6935     6934       -1     
  Lines      148113   148634     +521     
  Branches    42233    42529     +296     
==========================================
- Hits        52953    52944       -9     
- Misses      95160    95690     +530

Flag	Coverage Δ
air-discount-scheme-web	`0.00% <ø> (ø)`
api	`3.33% <ø> (ø)`
application-api-files	`61.73% <ø> (ø)`
application-core	`76.01% <ø> (ø)`
application-system-api	`38.74% <ø> (-0.01%)`	⬇️
application-template-api-modules	`27.82% <ø> (ø)`
application-templates-accident-notification	`28.83% <ø> (ø)`
application-templates-car-recycling	`3.12% <ø> (ø)`
application-templates-criminal-record	`25.78% <ø> (ø)`
application-templates-driving-license	`18.12% <ø> (ø)`
application-templates-estate	`13.84% <100.00%> (+0.04%)`	⬆️
application-templates-example-payment	`24.71% <ø> (ø)`
application-templates-financial-aid	`14.42% <ø> (ø)`
application-templates-general-petition	`23.13% <ø> (ø)`
application-templates-inheritance-report	`6.54% <ø> (ø)`
application-templates-marriage-conditions	`15.11% <ø> (ø)`
application-templates-mortgage-certificate	`43.60% <ø> (ø)`
application-templates-parental-leave	`29.95% <ø> (ø)`
application-types	`6.57% <ø> (ø)`
application-ui-components	`1.24% <ø> (ø)`
application-ui-shell	`22.54% <100.00%> (+0.03%)`	⬆️
clients-charge-fjs-v2	`28.35% <ø> (ø)`
clients-regulations	`42.87% <ø> (ø)`
contentful-apps	`4.72% <ø> (ø)`
financial-aid-backend	`51.40% <ø> (ø)`
financial-aid-shared	`17.88% <ø> (ø)`
island-ui-core	`31.02% <100.00%> (+0.10%)`	⬆️
judicial-system-web	`27.90% <100.00%> (+0.01%)`	⬆️
portals-admin-regulations-admin	`1.80% <ø> (ø)`
portals-core	`19.91% <100.00%> (+0.07%)`	⬆️
regulations	`16.78% <ø> (ø)`
shared-components	`30.12% <100.00%> (+0.06%)`	⬆️
shared-form-fields	`33.95% <100.00%> (+0.07%)`	⬆️
web	`2.44% <100.00%> (+0.02%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
libs/island-ui/core/src/lib/Text/Text.tsx	`94.73% <ø> (ø)`
libs/island-ui/theme/src/index.ts	`100.00% <ø> (ø)`
libs/island-ui/theme/src/lib/theme.ts	`98.46% <100.00%> (-0.03%)`	⬇️
libs/island-ui/theme/src/lib/tokens/figmaColors.ts	`100.00% <100.00%> (ø)`
.../island-ui/theme/src/lib/tokens/figmaPrimitives.ts	`100.00% <100.00%> (ø)`
.../island-ui/theme/src/lib/tokens/figmaTypography.ts	`100.00% <100.00%> (ø)`
libs/island-ui/theme/src/lib/tokens/tokens.ts	`100.00% <100.00%> (ø)`
...s/island-ui/theme/src/lib/typography/typography.ts	`100.00% <100.00%> (ø)`

... and 60 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3719969...fde1ac1. Read the comment docs.

feat: add typography from figma tokens

ac21809

disaerna added the deploy-feature Deploys features to dev label Dec 4, 2024

disaerna and others added 4 commits December 5, 2024 09:50

Merge branch 'main' into ui-core/figma-tokens-typography

80d87b1

Merge branch 'main' into ui-core/figma-tokens-typography

b2aa5d2

feat: script to convert to ts object WIP

af6bfcc

Merge branch 'main' into ui-core/figma-tokens-typography

fde1ac1

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(island-ui): add typography from figma tokens #17131

feat(island-ui): add typography from figma tokens #17131

disaerna commented Dec 4, 2024

coderabbitai bot commented Dec 4, 2024 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

github-actions bot commented Dec 4, 2024

datadog-island-is bot commented Dec 4, 2024 •

edited

Loading

codecov bot commented Dec 4, 2024 •

edited

Loading

feat(island-ui): add typography from figma tokens #17131

Are you sure you want to change the base?

feat(island-ui): add typography from figma tokens #17131

Conversation

disaerna commented Dec 4, 2024

...

What

Why

Screenshots / Gifs

Checklist:

coderabbitai bot commented Dec 4, 2024 • edited Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

github-actions bot commented Dec 4, 2024

datadog-island-is bot commented Dec 4, 2024 • edited Loading

Datadog Report

🔻 Code Coverage Decreases vs Default Branch (1)

codecov bot commented Dec 4, 2024 • edited Loading

Codecov Report

coderabbitai bot commented Dec 4, 2024 •

edited

Loading

datadog-island-is bot commented Dec 4, 2024 •

edited

Loading

codecov bot commented Dec 4, 2024 •

edited

Loading