feat(j-s): Add modal when revoking send to prison admin #17110
Conversation
WalkthroughThe pull request introduces new localization messages and updates existing strings within the judicial system's user interface. A new "cancel" message is added for case management, while additional messages related to revoking actions in the prison administration context are defined. Modifications to the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17110 +/- ##
==========================================
- Coverage 35.73% 35.70% -0.04%
==========================================
Files 6928 6955 +27
Lines 147811 147917 +106
Branches 42125 42196 +71
==========================================
- Hits 52816 52809 -7
- Misses 94995 95108 +113
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 214 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Datadog ReportBranch report: ✅ 0 Failed, 332 Passed, 0 Skipped, 1m 11.22s Total Time |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
apps/judicial-system/web/src/components/BlueBoxWithIcon/BlueBoxWithDate.tsx (1)
364-377: Consider handling loading state in the secondary button.While the implementation is good, consider disabling the secondary button (cancel) when the primary action is in progress to prevent potential race conditions.
<Modal title={formatMessage(strings.revokeSendToPrisonAdminModalTitle)} text={formatMessage(strings.revokeSendToPrisonAdminModalText, { courtCaseNumber: workingCase.courtCaseNumber, defendant: defendant.name, })} onPrimaryButtonClick={handleRevokeSendToPrisonAdmin} primaryButtonText={formatMessage(strings.revoke)} isPrimaryButtonLoading={isUpdatingDefendant} secondaryButtonText={formatMessage(core.cancel)} onSecondaryButtonClick={() => setModalVisible(undefined)} + isSecondaryButtonDisabled={isUpdatingDefendant} />
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (4)
apps/judicial-system/web/messages/Core/index.ts(1 hunks)apps/judicial-system/web/src/components/BlueBoxWithIcon/BlueBoxWithDate.strings.ts(1 hunks)apps/judicial-system/web/src/components/BlueBoxWithIcon/BlueBoxWithDate.tsx(6 hunks)apps/judicial-system/web/src/routes/PublicProsecutor/Indictments/SendToPrisonAdmin/SendToPrisonAdmin.strings.ts(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- apps/judicial-system/web/src/routes/PublicProsecutor/Indictments/SendToPrisonAdmin/SendToPrisonAdmin.strings.ts
🧰 Additional context used
📓 Path-based instructions (3)
apps/judicial-system/web/messages/Core/index.ts (1)
Pattern apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/judicial-system/web/src/components/BlueBoxWithIcon/BlueBoxWithDate.tsx (1)
Pattern apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/judicial-system/web/src/components/BlueBoxWithIcon/BlueBoxWithDate.strings.ts (1)
Pattern apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
📓 Learnings (2)
apps/judicial-system/web/src/components/BlueBoxWithIcon/BlueBoxWithDate.tsx (3)
Learnt from: oddsson
PR: island-is/island.is#16831
File: apps/judicial-system/web/src/components/BlueBoxWithIcon/BlueBoxWithDate.tsx:204-337
Timestamp: 2024-11-19T09:28:36.448Z
Learning: Buttons in this project are considered accessible as is, and adding additional ARIA attributes like `aria-label` and `aria-disabled` is not required unless specifically needed.
Learnt from: oddsson
PR: island-is/island.is#16495
File: apps/judicial-system/web/src/components/BlueBoxWithIcon/BlueBoxWithDate.tsx:102-103
Timestamp: 2024-11-12T15:15:11.835Z
Learning: In the TypeScript file `apps/judicial-system/web/src/components/BlueBoxWithIcon/BlueBoxWithDate.tsx`, within the `handleSetDate` function, the else block is intentionally kept to handle an unlikely scenario and should not be removed, even if it appears unnecessary due to prior validation checks.
Learnt from: oddsson
PR: island-is/island.is#16495
File: apps/judicial-system/web/src/components/BlueBoxWithIcon/BlueBoxWithDate.tsx:84-105
Timestamp: 2024-11-12T15:15:11.835Z
Learning: In `apps/judicial-system/web/src/components/BlueBoxWithIcon/BlueBoxWithDate.tsx`, the `setAndSendDefendantToServer` function handles errors internally, so additional error handling when calling it is not necessary.
apps/judicial-system/web/src/components/BlueBoxWithIcon/BlueBoxWithDate.strings.ts (1)
Learnt from: oddsson
PR: island-is/island.is#16495
File: apps/judicial-system/web/src/components/BlueBoxWithIcon/BlueBoxWithDate.strings.ts:3-3
Timestamp: 2024-11-12T15:15:20.157Z
Learning: In `apps/judicial-system/web/src/components/BlueBoxWithIcon/BlueBoxWithDate.strings.ts`, prefer not to add explicit TypeScript type definitions for the messages object.
🔇 Additional comments (5)
apps/judicial-system/web/src/components/BlueBoxWithIcon/BlueBoxWithDate.strings.ts (1)
86-101: LGTM! The new localization messages are well-structured.
The new messages follow consistent naming patterns and provide clear descriptions for translators.
apps/judicial-system/web/messages/Core/index.ts (1)
212-216: LGTM! The new core message is well-structured.
The cancel message follows consistent naming patterns and provides a clear description for translators.
apps/judicial-system/web/src/components/BlueBoxWithIcon/BlueBoxWithDate.tsx (3)
39-40: LGTM! Clean type definition and state management.
The VisibleModal type and state management for modal visibility are well-implemented.
Also applies to: 53-54
118-119: LGTM! Proper modal cleanup.
The modal is correctly hidden after the revoke action is completed.
344-344: LGTM! Modal trigger implementation.
The button correctly triggers the modal visibility state.
...m/web/src/routes/PublicProsecutor/Indictments/SendToPrisonAdmin/SendToPrisonAdmin.strings.ts
Show resolved
Hide resolved
apps/judicial-system/web/src/components/BlueBoxWithIcon/BlueBoxWithDate.strings.ts
Outdated
Show resolved
Hide resolved
…-send-to-prison-admin-modal
…-send-to-prison-admin-modal
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
apps/judicial-system/web/src/utils/hooks/useCaseList/index.tsx (1)
Line range hint
171-171: Consider adding user feedback when access is being determinedWhile the check for
limitedAccess === undefinedprevents race conditions, users might be confused why clicking doesn't work. Consider showing a loading state or toast message.if ( isTransitioningCase || isSendingNotification || clickedCase[0] === id || limitedAccess === undefined ) { + if (limitedAccess === undefined) { + toast.info(formatMessage({ id: 'checking.access' })) + } return }apps/judicial-system/web/src/components/BlueBoxWithIcon/BlueBoxWithDate.tsx (1)
39-40: Consider making VisibleModal type more extensibleWhile the current implementation works, consider using an enum or union type that's easier to extend for future modal types.
-type VisibleModal = 'REVOKE_SEND_TO_PRISON_ADMIN' +enum VisibleModal { + REVOKE_SEND_TO_PRISON_ADMIN = 'REVOKE_SEND_TO_PRISON_ADMIN' +}
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (2)
apps/judicial-system/web/src/components/BlueBoxWithIcon/BlueBoxWithDate.tsx(7 hunks)apps/judicial-system/web/src/utils/hooks/useCaseList/index.tsx(1 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
apps/judicial-system/web/src/utils/hooks/useCaseList/index.tsx (1)
Pattern apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/judicial-system/web/src/components/BlueBoxWithIcon/BlueBoxWithDate.tsx (1)
Pattern apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
📓 Learnings (1)
apps/judicial-system/web/src/components/BlueBoxWithIcon/BlueBoxWithDate.tsx (3)
Learnt from: oddsson
PR: island-is/island.is#16831
File: apps/judicial-system/web/src/components/BlueBoxWithIcon/BlueBoxWithDate.tsx:204-337
Timestamp: 2024-11-19T09:28:36.448Z
Learning: Buttons in this project are considered accessible as is, and adding additional ARIA attributes like `aria-label` and `aria-disabled` is not required unless specifically needed.
Learnt from: oddsson
PR: island-is/island.is#16495
File: apps/judicial-system/web/src/components/BlueBoxWithIcon/BlueBoxWithDate.tsx:102-103
Timestamp: 2024-11-12T15:15:11.835Z
Learning: In the TypeScript file `apps/judicial-system/web/src/components/BlueBoxWithIcon/BlueBoxWithDate.tsx`, within the `handleSetDate` function, the else block is intentionally kept to handle an unlikely scenario and should not be removed, even if it appears unnecessary due to prior validation checks.
Learnt from: oddsson
PR: island-is/island.is#16495
File: apps/judicial-system/web/src/components/BlueBoxWithIcon/BlueBoxWithDate.tsx:84-105
Timestamp: 2024-11-12T15:15:11.835Z
Learning: In `apps/judicial-system/web/src/components/BlueBoxWithIcon/BlueBoxWithDate.tsx`, the `setAndSendDefendantToServer` function handles errors internally, so additional error handling when calling it is not necessary.
🔇 Additional comments (3)
apps/judicial-system/web/src/utils/hooks/useCaseList/index.tsx (1)
145-145: LGTM: Correct dependency added to useCallback
The addition of 'features' to the dependency array is necessary as it's used within the callback to determine traffic violation cases. This prevents potential stale closure issues.
apps/judicial-system/web/src/components/BlueBoxWithIcon/BlueBoxWithDate.tsx (2)
364-377: LGTM: Modal implementation follows best practices
The modal implementation is well-structured with:
- Proper conditional rendering
- Internationalized text
- Loading state handling
- Clear action buttons
344-344: LGTM: Button implementation aligns with project standards
The button implementation correctly triggers the modal and follows the project's accessibility standards.
* Add modal when revoking send to prison admin * Update CF ids * Fix lint
Add modal when revoking send to prison admin
Asana
What
When users at the public prosecutor's office revoke a case from prisons, they now see a modal window asking if they are sure.
Why
So that it's less likely that someone revokes a case by accident.
Screenshots / Gifs
Screen.Recording.2024-12-03.at.11.42.54.mov
Checklist:
Summary by CodeRabbit
New Features
Bug Fixes
These changes improve localization support and user experience within the application.