feat(web): Organization pages - Show parent subpage even though standalone theme is not set

[RunarVestmann]

Organization pages - Show parent subpage even though standalone theme is not set

What

Skip the standalone theme check and instead default to fetching props for parent subpage (if there is a customnexterror then we fallback to organization subpages)

Why

So that content editors can continue working on parent subpages even though the theme isn't finalized

Checklist:

• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• Formatting passes locally with my changes
• I have rebased against main before asking for a review

Summary by CodeRabbit

• Bug Fixes
  • Improved error handling for the StandaloneParentSubpage to manage specific errors more effectively.
  • Enhanced robustness of the property retrieval process, ensuring better stability during asynchronous operations.

[coderabbitai]

Walkthrough

The changes in this pull request focus on enhancing the error handling logic within the getProps method of the StandaloneParentSubpage component. A try-catch block has been added to manage errors during the asynchronous retrieval of properties. This allows for specific handling of CustomNextError while re-throwing unexpected errors. The overall structure and logic of the method remain unchanged, ensuring that it continues to handle various lengths of the slugs array appropriately.

Changes

File Path	Change Summary
apps/web/pages/s/[...slugs]/index.tsx	Introduced a try-catch block in the getProps method for error handling, allowing specific management of CustomNextError and re-throwing of other errors. No changes to exported or public entity declarations.

Possibly related PRs

• fix(web): Add locale to organization page fetch #17015: Modifies the getProps method to add a lang property to the GraphQL query, relevant to the error handling logic.
• fix(web): Connect language toggler for standalone organization pages #17055: Integrates a global context provider in the StandaloneLayout component, which could interact with the error handling logic.
• chore(web): Move organization subpage content into separate component #16915: Refactors the SubPage component, potentially affecting error handling in the context of subpages.
• feat(web): Do not index org subpages that are 'standalone' #16717: Introduces a new condition in the OrganizationSubpageSyncService related to error handling for standalone pages.

Suggested labels

high priority

Suggested reviewers

• mannipje

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 35.68%. Comparing base (71774d0) to head (933d92e).

Files with missing lines	Patch %	Lines
apps/web/pages/s/[...slugs]/index.tsx	0.00%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #17096      +/-   ##
==========================================
- Coverage   35.68%   35.68%   -0.01%     
==========================================
  Files        6946     6946              
  Lines      147380   147382       +2     
  Branches    41894    41894              
==========================================
  Hits        52595    52595              
- Misses      94785    94787       +2     

Flag	Coverage Δ
web	2.44% <0.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
apps/web/pages/s/[...slugs]/index.tsx	0.00% <0.00%> (ø)

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71774d0...933d92e. Read the comment docs.

[datadog-island-is]

Datadog Report

Branch report: feature/web-organization-parent-subpage-shown-even-if-standalone-theme-not-set
Commit report: c3c8215
Test service: web

✅ 0 Failed, 84 Passed, 0 Skipped, 29.86s Total Time
➡️ Test Sessions change in coverage: 1 no change

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (2)

apps/web/pages/s/[...slugs]/index.tsx (2)

265-275: LGTM! Consider adding error logging.

The error handling implementation is well-structured and correctly differentiates between CustomNextError and other errors. This allows graceful fallback to regular subpages while preserving error propagation for unexpected issues.

Consider adding error logging before falling back to SubPage:

    } catch (error) {
      if (!(error instanceof CustomNextError)) {
        throw error
      }
+     console.error('Failed to load StandaloneParentSubpage:', error)
    }

---

265-275: Enhance NextJS implementation with best practices.

While the overall NextJS implementation is solid, consider these improvements:

1. Utilize NextJS's built-in error page for handling CustomNextError
2. Add proper typing to the getServerSidePropsWrapper
3. Address the ts-ignore comment by properly typing the withApollo HOC

For handling CustomNextError, consider implementing a custom error page:

// pages/404.tsx or pages/_error.tsx
import { CustomNextError } from '@island.is/web/units/errors'

interface ErrorProps {
  statusCode: number
  message?: string
}

function Error({ statusCode, message }: ErrorProps) {
  return (
    <div>
      <h1>{statusCode}</h1>
      <p>{message || 'An error occurred'}</p>
    </div>
  )
}

Error.getInitialProps = ({ err, res }) => {
  if (err instanceof CustomNextError) {
    if (res) {
      res.statusCode = err.statusCode
    }
    return { statusCode: err.statusCode, message: err.message }
  }
  return { statusCode: 500 }
}

export default Error

Also applies to: 1-400

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 71774d0 and 933d92e.

📒 Files selected for processing (1)

• apps/web/pages/s/[...slugs]/index.tsx (1 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

apps/web/pages/s/[...slugs]/index.tsx (1)

Pattern apps/**/*: "Confirm that the code adheres to the following:

• NextJS best practices, including file structure, API routes, and static generation methods.
• Efficient state management and server-side rendering techniques.
• Optimal use of TypeScript for component and utility type safety."