fix(user-notification): Args null variant fix #16703
Conversation
WalkthroughThe changes in the Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
…hub.com/island-is/island.is into user-notification/empty-args-contentful
apps/services/user-notification/src/app/modules/notifications/notifications.service.ts
Outdated
Show resolved
Hide resolved
rafnarnason
added
the
deprecated:automerge
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
apps/services/user-notification/src/app/modules/notifications/notifications.service.ts (2)
123-130: LGTM! Consider adding type assertion for better type safety.The changes correctly handle null values from Contentful by ensuring
argsis always an array. This aligns with the PR objective.Consider adding explicit type assertion for better type safety:
- args: template.args || [], // Ensure args is an array + args: template.args as string[] || [], // Ensure args is an array
148-151: LGTM! Consider enhancing error handling consistency.The changes correctly handle null values and maintain consistency with
getTemplates. The error message is clear and informative.Consider using the same error handling pattern as other methods in the service:
- throw new NotFoundException(`Template not found for ID: ${templateId}`); + this.logger.warn(`Template not found for ID: ${templateId}`, { templateId }); + throw new NotFoundException(`Template not found for ID: ${templateId}`);
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (1)
apps/services/user-notification/src/app/modules/notifications/notifications.service.ts(2 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
apps/services/user-notification/src/app/modules/notifications/notifications.service.ts (2)
Pattern apps/services/**/*: "Confirm that the code adheres to the following:
- NestJS architecture, including modules, services, and controllers.
- Dependency injection patterns and service encapsulation.
- Integration and unit testing coverage and practices."
Pattern apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
🔇 Additional comments (1)
apps/services/user-notification/src/app/modules/notifications/notifications.service.ts (1)
Line range hint 123-151: Verify test coverage for null args handling.
The changes to getTemplates and getTemplate affect dependent methods like validate and findMany. Please ensure test coverage includes:
- Handling of null args from Contentful
- Integration with dependent methods
- Error scenarios
Datadog ReportAll test runs ✅ 4 Total Test Services: 0 Failed, 4 Passed Test Services
🔻 Code Coverage Decreases vs Default Branch (1)
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16703 +/- ##
==========================================
+ Coverage 36.51% 36.56% +0.04%
==========================================
Files 6890 6881 -9
Lines 143801 143422 -379
Branches 40968 40849 -119
==========================================
- Hits 52511 52439 -72
+ Misses 91290 90983 -307
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 14 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
…hub.com/island-is/island.is into user-notification/empty-args-contentful
…er-notification/empty-args-contentful
…hub.com/island-is/island.is into user-notification/empty-args-contentful
contentful sends null instead of empty arrays for empty lists - this is to ensure declared value of dto for 0 argument templates
Attach a link to issue if relevant
What
Specify what you're trying to achieve
Why
Specify why you need to achieve this
Screenshots / Gifs
Attach Screenshots / Gifs to help reviewers understand the scope of the pull request
Checklist:
Summary by CodeRabbit
New Features
argsproperty is always an array, improving consistency and reliability of notifications.Bug Fixes