fix(my-pages): law and order breadcrumbs + button filter #16668
Conversation
WalkthroughThis pull request introduces several changes across multiple files in the service portal. Notable modifications include updates to CSS styles in Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Datadog ReportAll test runs ✅ 5 Total Test Services: 0 Failed, 4 Passed Test Services
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (2)
libs/service-portal/core/src/components/Filter/Filter.css.ts (1)
21-23: LGTM! Consider adding a comment to document the style's purpose.The child combinator selector improves style specificity by targeting only direct span children, preventing unintended style application to nested spans.
Add a comment to explain why the span needs 100% height:
+// Ensure direct span children fill the button height for proper alignment globalStyle(`${lgBtn} > span`, { height: '100%', })libs/service-portal/core/src/components/Filter/Filter.tsx (1)
Line range hint
1-21: Add JSDoc comment for the newlargeButtonprop.To maintain consistency with other props and improve code maintainability, please add documentation for the new prop.
additionalFilters?: ReactNode + /** Whether to apply large button styling. */ largeButton?: boolean
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (4)
libs/service-portal/core/src/components/Filter/Filter.css.ts(1 hunks)libs/service-portal/core/src/components/Filter/Filter.tsx(1 hunks)libs/service-portal/core/src/lib/messages.ts(1 hunks)libs/service-portal/law-and-order/src/lib/navigation.ts(1 hunks)
🧰 Additional context used
📓 Path-based instructions (4)
libs/service-portal/core/src/components/Filter/Filter.css.ts (1)
Pattern libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/service-portal/core/src/components/Filter/Filter.tsx (1)
Pattern libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/service-portal/core/src/lib/messages.ts (1)
Pattern libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/service-portal/law-and-order/src/lib/navigation.ts (1)
Pattern libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
🔇 Additional comments (3)
libs/service-portal/law-and-order/src/lib/navigation.ts (1)
18-18: LGTM! The navigation changes improve breadcrumb visibility.
The rename to myCourtCases and removal of breadcrumb hiding improves navigation clarity by making the section more personally relevant and visible in the breadcrumb trail.
Let's verify the message exists in the localization file:
✅ Verification successful
The navigation change is properly localized
The message key myCourtCases is correctly defined in the core messages file with the ID 'service.portal:my-court-cases', ensuring proper localization support for the navigation item.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify the myCourtCases message exists in messages.ts
# Expected: Should find the message definition
rg "myCourtCases.*=.*{" libs/service-portal/core/src/lib/messages.ts
Length of output: 170
Script:
#!/bin/bash
# Let's try a different approach to find the message definition
# First, let's check if the file exists
fd "messages.ts" libs/service-portal/law-and-order
# Then let's search for myCourtCases in a more reliable way
rg -l "myCourtCases" libs/service-portal/law-and-order
# Also check core messages
rg -l "myCourtCases" libs/service-portal/core
Length of output: 306
Script:
#!/bin/bash
# Let's check the content of both message files to verify the definition
rg -A 1 "myCourtCases" libs/service-portal/law-and-order/src/lib/messages.ts
rg -A 1 "myCourtCases" libs/service-portal/core/src/lib/messages.ts
Length of output: 203
libs/service-portal/core/src/components/Filter/Filter.tsx (1)
Line range hint 1-300: Well-structured and reusable component implementation.
The component follows best practices for reusability across NextJS apps:
- Strong TypeScript typing
- Clear component composition
- Good separation of concerns
- Effective context usage
libs/service-portal/core/src/lib/messages.ts (1)
1659-1662: LGTM! The new message follows i18n best practices.
The addition of myCourtCases message follows the established patterns:
- Proper namespace prefix in the ID
- Consistent casing and formatting
- Exported through the centralized messages object
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16668 +/- ##
=======================================
Coverage 36.67% 36.67%
=======================================
Files 6858 6858
Lines 142787 142787
Branches 40703 40703
=======================================
Hits 52364 52364
Misses 90423 90423
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
My pages
Screenshots / Gifs
Attach Screenshots / Gifs to help reviewers understand the scope of the pull request
Checklist:
Summary by CodeRabbit
New Features
largeButtonto the Filter component for enhanced styling flexibility.Improvements
m.courtCasestom.myCourtCasesfor clarity.Style