Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web): Pension calculator translations for 2025 comparison #16561

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

RunarVestmann
Copy link
Member

@RunarVestmann RunarVestmann commented Oct 25, 2024

Pension calculator translations for 2025 comparison

What

  • Translation strings needed for 2025 comparison view

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Formatting passes locally with my changes
  • I have rebased against main before asking for a review

Summary by CodeRabbit

  • New Features
    • Added new translation strings to enhance localization for the pension calculator application, including labels for various benefits related to disability and age supplements for 2025.

@RunarVestmann RunarVestmann added the deprecated:automerge (Disabled) Merge this PR as soon as all checks pass label Oct 25, 2024
@RunarVestmann RunarVestmann requested a review from a team as a code owner October 25, 2024 10:10
Copy link
Contributor

coderabbitai bot commented Oct 25, 2024

Walkthrough

The pull request introduces several new translation strings to the translationStrings object within the apps/web/screens/Organization/SocialInsuranceAdministration/translationStrings.ts file. These additions specifically relate to benefits associated with disability pensions and age supplements for the year 2025, thereby enhancing the localization support for the pension calculator application.

Changes

File Path Change Summary
apps/web/screens/Organization/SocialInsuranceAdministration/translationStrings.ts Added new translation strings: REIKNH.ORORKA_ALDURSV_HUPPBOT_2025, REIKNH.ORORKA_HUPPBOT_2025, REIKNH.ORORKA_ALDURSV_2025, REIKNH.ORORKA_2025.

Possibly related PRs

Suggested reviewers

  • mannipje

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 70a3148 and 8d4b447.

📒 Files selected for processing (1)
  • apps/web/screens/Organization/SocialInsuranceAdministration/translationStrings.ts (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
apps/web/screens/Organization/SocialInsuranceAdministration/translationStrings.ts (1)

Pattern apps/**/*: "Confirm that the code adheres to the following:

  • NextJS best practices, including file structure, API routes, and static generation methods.
  • Efficient state management and server-side rendering techniques.
  • Optimal use of TypeScript for component and utility type safety."
🔇 Additional comments (2)
apps/web/screens/Organization/SocialInsuranceAdministration/translationStrings.ts (2)

923-928: LGTM! Translation string follows the established pattern.

The translation string for the full combination (pension + age supplement + housing supplement) is well structured with clear description and follows the naming convention.


929-943: LGTM! Translation strings are consistent and complete.

The remaining translation strings for various disability pension combinations in 2025 are:

  • Well organized with consistent naming (REIKNH.ORORKA_*_2025)
  • Include clear descriptions that match their purposes
  • Follow the established pattern for translations

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.80%. Comparing base (70a3148) to head (8d4b447).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #16561   +/-   ##
=======================================
  Coverage   36.80%   36.80%           
=======================================
  Files        6854     6854           
  Lines      142215   142215           
  Branches    40549    40549           
=======================================
  Hits        52336    52336           
  Misses      89879    89879           
Flag Coverage Δ
web 1.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ocialInsuranceAdministration/translationStrings.ts 0.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70a3148...8d4b447. Read the comment docs.

@datadog-island-is
Copy link

Datadog Report

Branch report: feature/web-pension-calculator-translation-strings
Commit report: 2cfa73f
Test service: web

✅ 0 Failed, 84 Passed, 0 Skipped, 29.84s Total Time
➡️ Test Sessions change in coverage: 1 no change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecated:automerge (Disabled) Merge this PR as soon as all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants