Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(auth-admin): Hotfix: Auditlog for webhook and minor UI fixes #16414

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

GunnlaugurG
Copy link
Member

...

Attach a link to issue if relevant

What

Specify what you're trying to achieve

Why

Specify why you need to achieve this

Screenshots / Gifs

Attach Screenshots / Gifs to help reviewers understand the scope of the pull request

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Formatting passes locally with my changes
  • I have rebased against main before asking for a review

GunnlaugurG and others added 2 commits October 16, 2024 09:17
* audit log delegation-admin webhook

* log the response in resource and request in meta

* remove audit in decorator

* make createdBy optional

* attempt to fix pipe

* attempt to fix pipe

* merge with main

* fix tests

---------

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
…m me list (#16400)

* fixes wrong validTo date in DelegationViewModal and show delete button for outgoing delegation

* remove log

* chore: nx format:write update dirty files

---------

Co-authored-by: andes-it <[email protected]>
@GunnlaugurG GunnlaugurG requested review from a team as code owners October 16, 2024 09:20
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 36.87%. Comparing base (855831b) to head (98ebf6c).
Report is 2 commits behind head on release/32.1.0.

Files with missing lines Patch % Lines
...legations/admin/delegation-admin-custom.service.ts 0.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           release/32.1.0   #16414   +/-   ##
===============================================
  Coverage           36.87%   36.87%           
===============================================
  Files                6801     6801           
  Lines              140594   140600    +6     
  Branches            39975    39979    +4     
===============================================
+ Hits                51842    51848    +6     
  Misses              88752    88752           
Flag Coverage Δ
api-domains-auth-admin 48.48% <ø> (ø)
application-system-api 41.66% <ø> (ø)
application-template-api-modules 24.30% <ø> (ø)
services-auth-admin-api 52.17% <66.66%> (+0.04%) ⬆️
services-auth-delegation-api 57.66% <0.00%> (-0.01%) ⬇️
services-auth-ids-api 51.71% <0.00%> (-0.02%) ⬇️
services-auth-personal-representative 45.42% <0.00%> (-0.01%) ⬇️
services-auth-personal-representative-public 41.51% <0.00%> (+0.02%) ⬆️
services-auth-public-api 49.21% <0.00%> (-0.01%) ⬇️
services-user-notification 47.04% <ø> (ø)
services-user-profile 62.07% <ø> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../app/v2/delegations/delegation-admin.controller.ts 97.61% <100.00%> (+0.32%) ⬆️
...src/app/delegations/delegation-index.controller.ts 93.75% <ø> (ø)
...b/src/lib/delegations/delegations-index.service.ts 87.01% <ø> (ø)
...legations/admin/delegation-admin-custom.service.ts 78.26% <0.00%> (-0.69%) ⬇️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 855831b...98ebf6c. Read the comment docs.

@datadog-island-is
Copy link

Datadog Report

All test runs 1d6a7b2 🔗

13 Total Test Services: 0 Failed, 13 Passed
🔻 Test Sessions change in coverage: 8 decreased, 1 increased (+0.05%), 19 no change

Test Services
This report shows up to 10 services
Service Name Failed Known Flaky New Flaky Passed Skipped Total Time Code Coverage Change Test Service View
api 0 0 0 4 0 3.19s 1 no change Link
api-domains-auth-admin 0 0 0 18 0 14.25s 1 no change Link
application-system-api 0 0 0 120 2 3m 28.51s 1 no change Link
application-template-api-modules 0 0 0 134 0 2m 1.37s 1 decreased (-4.08%) Link
auth-api-lib 0 0 0 20 0 31.41s 1 no change Link
services-auth-admin-api 0 0 0 128 0 3m 5.11s 1 decreased (-0.02%) Link
services-auth-delegation-api 0 0 0 256 0 3m 10.13s 1 decreased (-0.02%) Link
services-auth-ids-api 0 0 0 152 0 57.27s 1 decreased (-0.01%) Link
services-auth-personal-representative 0 0 0 59 0 1m 23.23s 1 decreased (-0.02%) Link
services-auth-personal-representative-public 0 0 0 10 0 26.09s 1 decreased (-0.02%) Link

🔻 Code Coverage Decreases vs Default Branch (8)

This report shows up to 5 code coverage decreases.

  • application-template-api-modules - jest 26.02% (-4.08%) - Details
  • services-auth-admin-api - jest 47.54% (-0.02%) - Details
  • services-auth-personal-representative - jest 44% (-0.02%) - Details
  • services-user-profile - jest 52.72% (-0.02%) - Details
  • services-auth-public-api - jest 45.9% (-0.02%) - Details

@saevarma saevarma added the deprecated:automerge (Disabled) Merge this PR as soon as all checks pass label Oct 16, 2024
@kodiakhq kodiakhq bot merged commit 415c1e1 into release/32.1.0 Oct 16, 2024
79 checks passed
@kodiakhq kodiakhq bot deleted the hotfix/delegation-admin-fixes branch October 16, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecated:automerge (Disabled) Merge this PR as soon as all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants