Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(j-s): Rovot Indictment Subject #15343

Merged
merged 2 commits into from
Jun 26, 2024
Merged

fix(j-s): Rovot Indictment Subject #15343

merged 2 commits into from
Jun 26, 2024

Conversation

gudjong
Copy link
Member

@gudjong gudjong commented Jun 25, 2024

Rovot Indictment Subject

Breyta subject í ákæru robot pósti úr "Ákæra" í nafn héraðsdóms

What

  • Replaces the text "Ákæra" with the relevant district court name in the subject of indictment case emails to the court robot.

Why

  • The robot needs to know to which district court the case belongs.

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Formatting passes locally with my changes
  • I have rebased against main before asking for a review

Summary by CodeRabbit

  • Enhancements

    • Added court name to various case update functionalities, improving the detail and accuracy of court-related information.
    • Updated email subject lines to include court name when available, enhancing the clarity of communication.
  • Testing Improvements

    • Enhanced test cases to include court name in mock data and function calls, ensuring better coverage and accuracy in tests.

@gudjong gudjong requested a review from a team as a code owner June 25, 2024 14:23
Copy link
Contributor

coderabbitai bot commented Jun 25, 2024

Walkthrough

In this update, the InternalCaseService and associated test files are modified to incorporate the court.name property in various method calls for case updates. Additionally, the CourtService methods are updated to accept an optional courtName parameter, which influences the construction of email subjects. Key method names are also revised in mock services within the tests to align with these changes.

Changes

File(s) Change Summary
.../internalCase.service.ts Introduced inclusion of theCase.court?.name as an argument in key method calls.
.../deliverIndictmentAssignedRolesToCourt.spec.ts
.../deliverIndictmentDefenderInfoToCourt.spec.ts
.../deliverIndictmentInfoToCourt.spec.ts
Added court object with name property in theCase. Updated parameters passed to mock court service methods to include courtName.
.../court.service.ts Added optional courtName parameter to relevant methods. Adjusted email subject construction to include courtName.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant InternalCaseService
    participant CourtService

    User ->> InternalCaseService: Assign Roles to Court
    InternalCaseService -->> InternalCaseService: Extract Case Details
    InternalCaseService ->> CourtService: updateIndictmentCaseWithAssignedRoles(user, caseId, courtName, courtCaseNumber, assignedRole)

    User ->> InternalCaseService: Deliver Defender Info to Court
    InternalCaseService -->> InternalCaseService: Extract Case Details
    InternalCaseService ->> CourtService: updateIndictmentCaseWithDefenderInfo(user, caseId, courtName, courtCaseNumber, defendants)

    User ->> InternalCaseService: Deliver Indictment Info to Court
    InternalCaseService -->> InternalCaseService: Extract Case Details
    InternalCaseService ->> CourtService: updateIndictmentCaseWithIndictmentInfo(user, caseId, courtName, courtCaseNumber, dates, prosecutor)

    CourtService ->> CourtService: Construct Email Subject
Loading

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@datadog-island-is
Copy link

Datadog Report

Branch report: j-s/fix-robot-subject
Commit report: e6dce8a
Test service: judicial-system-backend

✅ 0 Failed, 19947 Passed, 0 Skipped, 17m 35.2s Total Time
➡️ Test Sessions change in coverage: 1 no change

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 36.99%. Comparing base (a75bb68) to head (52993bd).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #15343      +/-   ##
==========================================
- Coverage   37.05%   36.99%   -0.06%     
==========================================
  Files        6538     6538              
  Lines      133102   132808     -294     
  Branches    38131    38086      -45     
==========================================
- Hits        49320    49137     -183     
+ Misses      83782    83671     -111     
Flag Coverage Δ
air-discount-scheme-backend 53.99% <ø> (ø)
api 3.44% <ø> (ø)
api-catalogue-services 77.85% <ø> (ø)
auth-react 23.09% <ø> (ø)
auth-shared 75.00% <ø> (ø)
services-auth-admin-api 51.29% <ø> (ø)
services-auth-delegation-api 61.62% <ø> (ø)
services-auth-ids-api 54.92% <ø> (+0.01%) ⬆️
services-auth-personal-representative 48.60% <ø> (-0.04%) ⬇️
services-auth-personal-representative-public 44.41% <ø> (ø)
services-auth-public-api 51.40% <ø> (ø)
services-university-gateway 48.56% <ø> (+0.05%) ⬆️
shared-utils 29.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ckend/src/app/modules/case/internalCase.service.ts 85.71% <100.00%> (+0.10%) ⬆️
...tem/backend/src/app/modules/court/court.service.ts 39.25% <0.00%> (ø)

... and 215 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a75bb68...52993bd. Read the comment docs.

@oddsson oddsson added the automerge Merge this PR as soon as all checks pass label Jun 26, 2024
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Outside diff range and nitpick comments (3)
apps/judicial-system/backend/src/app/modules/case/test/internalCaseController/deliverIndictmentAssignedRolesToCourt.spec.ts (1)

Line range hint 63-64: Avoid assignments within expressions

Using assignments within expressions can lead to code that is hard to read and maintain. It's recommended to separate the assignment and the expression.

- await internalCaseController.deliverIndictmentAssignedRoleToCourt(caseId, theCase, { user }, nationalId).then((result) => (then.result = result)).catch((error) => (then.error = error))
+ try {
+   then.result = await internalCaseController.deliverIndictmentAssignedRoleToCourt(caseId, theCase, { user }, nationalId);
+ } catch (error) {
+   then.error = error;
+ }
apps/judicial-system/backend/src/app/modules/case/test/internalCaseController/deliverIndictmentDefenderInfoToCourt.spec.ts (1)

Line range hint 69-72: Avoid assignments within expressions

Similar to the previous file, it's better to avoid assignments within expressions to improve readability and maintainability.

- await internalCaseController.deliverIndictmentDefenderInfoToCourt(caseId, theCase, { user }).then((result) => (then.result = result)).catch((error) => (then.error = error))
+ try {
+   then.result = await internalCaseController.deliverIndictmentDefenderInfoToCourt(caseId, theCase, { user });
+ } catch (error) {
+   then.error = error;
+ }
apps/judicial-system/backend/src/app/modules/case/test/internalCaseController/deliverIndictmentInfoToCourt.spec.ts (1)

Line range hint 77-79: Avoid assignments within expressions

As noted in previous files, it's best to avoid assignments within expressions. Splitting these into separate statements can enhance clarity and maintainability.

- await internalCaseController.deliverIndictmentInfoToCourt(caseId, theCase, { user }).then((result) => (then.result = result)).catch((error) => (then.error = error))
+ try {
+   then.result = await internalCaseController.deliverIndictmentInfoToCourt(caseId, theCase, { user });
+ } catch (error) {
+   then.error = error;
+ }
Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between a75bb68 and 52993bd.

Files selected for processing (5)
  • apps/judicial-system/backend/src/app/modules/case/internalCase.service.ts (3 hunks)
  • apps/judicial-system/backend/src/app/modules/case/test/internalCaseController/deliverIndictmentAssignedRolesToCourt.spec.ts (2 hunks)
  • apps/judicial-system/backend/src/app/modules/case/test/internalCaseController/deliverIndictmentDefenderInfoToCourt.spec.ts (4 hunks)
  • apps/judicial-system/backend/src/app/modules/case/test/internalCaseController/deliverIndictmentInfoToCourt.spec.ts (3 hunks)
  • apps/judicial-system/backend/src/app/modules/court/court.service.ts (6 hunks)
Additional context used
Path-based instructions (5)
apps/judicial-system/backend/src/app/modules/case/test/internalCaseController/deliverIndictmentAssignedRolesToCourt.spec.ts (1)

Pattern apps/**/*: "Confirm that the code adheres to the following:

  • NextJS best practices, including file structure, API routes, and static generation methods.
  • Efficient state management and server-side rendering techniques.
  • Optimal use of TypeScript for component and utility type safety."
apps/judicial-system/backend/src/app/modules/case/test/internalCaseController/deliverIndictmentDefenderInfoToCourt.spec.ts (1)

Pattern apps/**/*: "Confirm that the code adheres to the following:

  • NextJS best practices, including file structure, API routes, and static generation methods.
  • Efficient state management and server-side rendering techniques.
  • Optimal use of TypeScript for component and utility type safety."
apps/judicial-system/backend/src/app/modules/case/test/internalCaseController/deliverIndictmentInfoToCourt.spec.ts (1)

Pattern apps/**/*: "Confirm that the code adheres to the following:

  • NextJS best practices, including file structure, API routes, and static generation methods.
  • Efficient state management and server-side rendering techniques.
  • Optimal use of TypeScript for component and utility type safety."
apps/judicial-system/backend/src/app/modules/court/court.service.ts (1)

Pattern apps/**/*: "Confirm that the code adheres to the following:

  • NextJS best practices, including file structure, API routes, and static generation methods.
  • Efficient state management and server-side rendering techniques.
  • Optimal use of TypeScript for component and utility type safety."
apps/judicial-system/backend/src/app/modules/case/internalCase.service.ts (1)

Pattern apps/**/*: "Confirm that the code adheres to the following:

  • NextJS best practices, including file structure, API routes, and static generation methods.
  • Efficient state management and server-side rendering techniques.
  • Optimal use of TypeScript for component and utility type safety."
Biome
apps/judicial-system/backend/src/app/modules/case/test/internalCaseController/deliverIndictmentAssignedRolesToCourt.spec.ts

[error] 63-63: The assignment should not be in an expression. (lint/suspicious/noAssignInExpressions)

The use of assignments in expressions is confusing.
Expressions are often considered as side-effect free.


[error] 64-64: The assignment should not be in an expression. (lint/suspicious/noAssignInExpressions)

The use of assignments in expressions is confusing.
Expressions are often considered as side-effect free.

apps/judicial-system/backend/src/app/modules/case/test/internalCaseController/deliverIndictmentDefenderInfoToCourt.spec.ts

[error] 69-70: The assignment should not be in an expression. (lint/suspicious/noAssignInExpressions)

The use of assignments in expressions is confusing.
Expressions are often considered as side-effect free.


[error] 70-72: The assignment should not be in an expression. (lint/suspicious/noAssignInExpressions)

The use of assignments in expressions is confusing.
Expressions are often considered as side-effect free.

apps/judicial-system/backend/src/app/modules/case/test/internalCaseController/deliverIndictmentInfoToCourt.spec.ts

[error] 77-78: The assignment should not be in an expression. (lint/suspicious/noAssignInExpressions)

The use of assignments in expressions is confusing.
Expressions are often considered as side-effect free.


[error] 78-79: The assignment should not be in an expression. (lint/suspicious/noAssignInExpressions)

The use of assignments in expressions is confusing.
Expressions are often considered as side-effect free.

apps/judicial-system/backend/src/app/modules/court/court.service.ts

[error] 144-145: Decorators are not valid here. (parse)

Decorators are only valid on class declarations, class expressions, and class methods.
You can enable parameter decorators by setting the unsafeParameterDecoratorsEnabled option to true in your configuration file.


[error] 145-146: Decorators are not valid here. (parse)

Decorators are only valid on class declarations, class expressions, and class methods.
You can enable parameter decorators by setting the unsafeParameterDecoratorsEnabled option to true in your configuration file.


[error] 147-147: Decorators are not valid here. (parse)

Decorators are only valid on class declarations, class expressions, and class methods.
You can enable parameter decorators by setting the unsafeParameterDecoratorsEnabled option to true in your configuration file.


[error] 149-150: Decorators are not valid here. (parse)

Decorators are only valid on class declarations, class expressions, and class methods.
You can enable parameter decorators by setting the unsafeParameterDecoratorsEnabled option to true in your configuration file.


[error] 227-228: This default parameter should follow the last required parameter or should be a required parameter. (lint/style/useDefaultParameterLast)

The last required parameter is here:

A default parameter that precedes a required parameter cannot be omitted at call site.
Unsafe fix: Turn the parameter into a required parameter.


[error] 228-229: This default parameter should follow the last required parameter or should be a required parameter. (lint/style/useDefaultParameterLast)

The last required parameter is here:

A default parameter that precedes a required parameter cannot be omitted at call site.
Unsafe fix: Turn the parameter into a required parameter.


[error] 281-281: This default parameter should follow the last required parameter or should be a required parameter. (lint/style/useDefaultParameterLast)

The last required parameter is here:

A default parameter that precedes a required parameter cannot be omitted at call site.
Unsafe fix: Turn the parameter into a required parameter.


[error] 281-282: This default parameter should follow the last required parameter or should be a required parameter. (lint/style/useDefaultParameterLast)

The last required parameter is here:

A default parameter that precedes a required parameter cannot be omitted at call site.
Unsafe fix: Turn the parameter into a required parameter.


[error] 327-328: This default parameter should follow the last required parameter or should be a required parameter. (lint/style/useDefaultParameterLast)

The last required parameter is here:

A default parameter that precedes a required parameter cannot be omitted at call site.
Unsafe fix: Turn the parameter into a required parameter.

apps/judicial-system/backend/src/app/modules/case/internalCase.service.ts

[error] 149-149: Decorators are not valid here. (parse)

Decorators are only valid on class declarations, class expressions, and class methods.
You can enable parameter decorators by setting the unsafeParameterDecoratorsEnabled option to true in your configuration file.


[error] 150-150: Decorators are not valid here. (parse)

Decorators are only valid on class declarations, class expressions, and class methods.
You can enable parameter decorators by setting the unsafeParameterDecoratorsEnabled option to true in your configuration file.


[error] 152-152: Decorators are not valid here. (parse)

Decorators are only valid on class declarations, class expressions, and class methods.
You can enable parameter decorators by setting the unsafeParameterDecoratorsEnabled option to true in your configuration file.


[error] 153-153: Decorators are not valid here. (parse)

Decorators are only valid on class declarations, class expressions, and class methods.
You can enable parameter decorators by setting the unsafeParameterDecoratorsEnabled option to true in your configuration file.


[error] 155-155: Decorators are not valid here. (parse)

Decorators are only valid on class declarations, class expressions, and class methods.
You can enable parameter decorators by setting the unsafeParameterDecoratorsEnabled option to true in your configuration file.


[error] 157-157: Decorators are not valid here. (parse)

Decorators are only valid on class declarations, class expressions, and class methods.
You can enable parameter decorators by setting the unsafeParameterDecoratorsEnabled option to true in your configuration file.


[error] 159-159: Decorators are not valid here. (parse)

Decorators are only valid on class declarations, class expressions, and class methods.
You can enable parameter decorators by setting the unsafeParameterDecoratorsEnabled option to true in your configuration file.


[error] 161-161: Decorators are not valid here. (parse)

Decorators are only valid on class declarations, class expressions, and class methods.
You can enable parameter decorators by setting the unsafeParameterDecoratorsEnabled option to true in your configuration file.


[error] 163-163: Decorators are not valid here. (parse)

Decorators are only valid on class declarations, class expressions, and class methods.
You can enable parameter decorators by setting the unsafeParameterDecoratorsEnabled option to true in your configuration file.


[error] 165-165: Decorators are not valid here. (parse)

Decorators are only valid on class declarations, class expressions, and class methods.
You can enable parameter decorators by setting the unsafeParameterDecoratorsEnabled option to true in your configuration file.


[error] 167-167: Decorators are not valid here. (parse)

Decorators are only valid on class declarations, class expressions, and class methods.
You can enable parameter decorators by setting the unsafeParameterDecoratorsEnabled option to true in your configuration file.


[error] 169-169: Decorators are not valid here. (parse)

Decorators are only valid on class declarations, class expressions, and class methods.
You can enable parameter decorators by setting the unsafeParameterDecoratorsEnabled option to true in your configuration file.


[error] 171-171: Decorators are not valid here. (parse)

Decorators are only valid on class declarations, class expressions, and class methods.
You can enable parameter decorators by setting the unsafeParameterDecoratorsEnabled option to true in your configuration file.


[error] 173-173: Decorators are not valid here. (parse)

Decorators are only valid on class declarations, class expressions, and class methods.
You can enable parameter decorators by setting the unsafeParameterDecoratorsEnabled option to true in your configuration file.


[error] 175-175: Decorators are not valid here. (parse)

Decorators are only valid on class declarations, class expressions, and class methods.
You can enable parameter decorators by setting the unsafeParameterDecoratorsEnabled option to true in your configuration file.


[error] 177-177: Decorators are not valid here. (parse)

Decorators are only valid on class declarations, class expressions, and class methods.
You can enable parameter decorators by setting the unsafeParameterDecoratorsEnabled option to true in your configuration file.


[error] 179-179: Decorators are not valid here. (parse)

Decorators are only valid on class declarations, class expressions, and class methods.
You can enable parameter decorators by setting the unsafeParameterDecoratorsEnabled option to true in your configuration file.


[error] 896-896: Change to an optional chain. (lint/complexity/useOptionalChain)

Unsafe fix: Change to an optional chain.


[error] 878-878: Avoid the use of spread (...) syntax on accumulators. (lint/performance/noAccumulatingSpread)

Spread syntax should be avoided on accumulators (like those in .reduce) because it causes a time complexity of O(n^2).
Consider methods such as .splice or .push instead.

Additional comments not posted (12)
apps/judicial-system/backend/src/app/modules/case/test/internalCaseController/deliverIndictmentAssignedRolesToCourt.spec.ts (2)

25-31: Addition of courtName to theCase object

The addition of courtName to the theCase object is consistent with the PR's objective to include the court's name in various methods. This change should help in ensuring that the correct court name is used in the test scenarios.


80-80: Ensure correct parameters in mock function call

It's good to see the test updated to include courtName in the toHaveBeenCalledWith method. This change aligns with the updates in the main service, ensuring that the tests remain relevant and accurate.

apps/judicial-system/backend/src/app/modules/case/test/internalCaseController/deliverIndictmentDefenderInfoToCourt.spec.ts (2)

26-32: Addition of courtName to theCase object

This change is consistent with the PR's objectives and ensures that the court name is correctly passed to methods that require it. Good to see consistency across test files.


80-85: Updated function call to include courtName

The update to the toHaveBeenCalledWith method to include courtName ensures that the tests are aligned with the changes in the service methods. This is crucial for maintaining the accuracy of the tests.

apps/judicial-system/backend/src/app/modules/case/test/internalCaseController/deliverIndictmentInfoToCourt.spec.ts (2)

Line range hint 32-50: Addition of courtName to theCase object

This consistent addition across test files ensures that courtName is appropriately included in the test setups, aligning with the PR's objectives.


96-98: Updated function call to include courtName

The update to the toHaveBeenCalledWith method to include courtName ensures that the tests are accurately testing the updated service methods. This consistency is crucial for valid test results.

apps/judicial-system/backend/src/app/modules/court/court.service.ts (3)

Line range hint 565-657: Updated service methods to include courtName

The addition of courtName as an optional parameter in these methods is consistent with the PR's objectives. This change ensures that the court's name can be included in various case updates, which is crucial for the robot system's correct identification and processing.


862-862: Enhanced sendToRobot method to include logging

The update to the sendToRobot method to include logging and token acquisition is well-implemented. This ensures better traceability and error handling for the emails sent to the court robot.


Line range hint 144-150: Check decorator usage

The static analysis has flagged the use of decorators in potentially incorrect places. Please verify that these decorators are applied correctly as per NestJS's documentation.

Verification successful

Check decorator usage

The @Inject, @InjectModel, and @InjectConnection decorators are correctly used for dependency injection in the court.service.ts file. These decorators are applied to class properties, which aligns with NestJS's standard practices.

  • @InjectConnection() private readonly sequelize: Sequelize
  • @InjectModel(RobotLog) private readonly robotLogModel: typeof RobotLog
  • @Inject(LOGGER_PROVIDER) private readonly logger: Logger
  • @Inject(courtModuleConfig.KEY) private readonly config: ConfigType<typeof courtModuleConfig>
Scripts executed

The following scripts were executed for the analysis:


Script:

#!/bin/bash
# Description: Check for correct usage of decorators in NestJS.

# Test: Search for decorator usage in TypeScript files. Expect: Decorators should only be used in allowed locations.
rg --type typescript $'@Inject'

Length of output: 65



Script:

#!/bin/bash
# Description: Check for correct usage of @Inject decorators in the specified file and line range.

# Search for @Inject decorator in the court.service.ts file
rg --type-add 'ts:*.ts' --type ts '@Inject' apps/judicial-system/backend/src/app/modules/court/court.service.ts

Length of output: 361

apps/judicial-system/backend/src/app/modules/case/internalCase.service.ts (3)

591-591: Code changes are correctly implemented for delivering indictment info to court.

The addition of the courtName parameter aligns with the PR's objectives to ensure the court's name is included in communications. The changes are correctly implemented in the method signature and call.

Also applies to: 628-631


628-631: Proper implementation of court name inclusion in defender info delivery.

The courtName parameter is correctly added to enhance the accuracy of the court identification in the judicial process.


668-668: Correct inclusion of court name in assigned roles delivery.

The addition of courtName ensures that the court is correctly identified, which is crucial for the functionality of the system in assigning roles.

@kodiakhq kodiakhq bot merged commit cb198a7 into main Jun 26, 2024
246 checks passed
@kodiakhq kodiakhq bot deleted the j-s/fix-robot-subject branch June 26, 2024 16:42
sigruntg pushed a commit that referenced this pull request Jun 27, 2024
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
snaerseljan pushed a commit that referenced this pull request Jul 2, 2024
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
@coderabbitai coderabbitai bot mentioned this pull request Nov 5, 2024
6 tasks
@coderabbitai coderabbitai bot mentioned this pull request Nov 15, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge this PR as soon as all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants