feat(ids-auth): adding @skagafjordur.is/ibuagatt to delegation config #14913
Conversation
…ompanies to grant the delegation
WalkthroughA new scope configuration has been introduced in the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
jonarnarbriem
changed the title
jonarnarbriem
added
the
deprecated:automerge
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14913 +/- ##
=======================================
Coverage 37.10% 37.10%
=======================================
Files 6353 6353
Lines 129358 129356 -2
Branches 36934 36933 -1
=======================================
+ Hits 47994 47996 +2
+ Misses 81364 81360 -4 Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range and nitpick comments (1)
libs/auth-api-lib/src/lib/delegations/DelegationConfig.ts (1)
98-105: The addition of@skagafjordur.is/ibuagatttocustomScopeRulesis correctly implemented.Consider adding a comment explaining why this specific scope is important or its intended use, to aid future maintainability.
Review Details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- libs/auth-api-lib/src/lib/delegations/DelegationConfig.ts (1 hunks)
Additional Context Used
Path-based Instructions (1)
libs/auth-api-lib/src/lib/delegations/DelegationConfig.ts (1)
Pattern
libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
Datadog ReportAll test runs ✅ 27 Total Test Services: 0 Failed, 27 Passed Test ServicesThis report shows up to 10 services
🔻 Code Coverage Decreases vs Default Branch (2) |
individuals should not be able to grant the delegation @skagafjordur.is/ibuagatt
...
Attach a link to issue if relevant
What
Specify what you're trying to achieve
Why
Specify why you need to achieve this
Screenshots / Gifs
Attach Screenshots / Gifs to help reviewers understand the scope of the pull request
Checklist:
Summary by CodeRabbit
@skagafjordur.is/ibuagatt, supportingProcurationHolderandCustomdelegation types.