fix(application-driving-license): Fix license requirements #14784
Conversation
WalkthroughThe recent changes in the driving license application codebase involve updating the conditions for disabling certain sections within the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- libs/application/templates/driving-license/src/forms/prerequisites/sectionApplicationFor.ts (2 hunks)
Additional Context Used
Path-based Instructions (1)
libs/application/templates/driving-license/src/forms/prerequisites/sectionApplicationFor.ts (1)
Pattern
libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
Additional comments not posted (2)
libs/application/templates/driving-license/src/forms/prerequisites/sectionApplicationFor.ts (2)
53-53: Update thedisabledcondition to check for the absence of acurrentLicense.The change simplifies the condition and ensures that the full license option is only enabled when there is no current license.
62-62: Update thedisabledcondition to check for the absence of acurrentLicense.The change ensures that the BE license option is only enabled when there is no current license, maintaining consistency with the other license options.
There was a problem hiding this comment.
Actionable comments posted: 2
Review Details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (2)
- libs/application/templates/driving-license/src/forms/prerequisites/sectionApplicationFor.ts (3 hunks)
- libs/application/templates/driving-license/src/lib/types.ts (1 hunks)
Files skipped from review due to trivial changes (1)
- libs/application/templates/driving-license/src/forms/prerequisites/sectionApplicationFor.ts
Additional Context Used
Path-based Instructions (1)
libs/application/templates/driving-license/src/lib/types.ts (1)
Pattern
libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #14784 +/- ##
==========================================
- Coverage 36.97% 36.97% -0.01%
==========================================
Files 6307 6307
Lines 128360 128364 +4
Branches 36632 36636 +4
==========================================
Hits 47467 47467
- Misses 80893 80897 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
Datadog ReportAll test runs ✅ 5 Total Test Services: 0 Failed, 5 Passed Test Services
🔻 Code Coverage Decreases vs Default Branch (2) |
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- libs/application/templates/driving-license/src/forms/prerequisites/sectionApplicationFor.ts (3 hunks)
Files skipped from review as they are similar to previous changes (1)
- libs/application/templates/driving-license/src/forms/prerequisites/sectionApplicationFor.ts
* fix(application-driving-license): Fix license requirements * fix(application-driving-license): Fix license requirements * fix(application-driving-license): Fix license requirements --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Removing accidental fake data introduction to requirements.
Checklist:
Summary by CodeRabbit
DrivingLicenseCategoryand modified theDrivingLicensetype to includecategories.