Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(j-s): Reviewer completes indictment review #14762

Merged
merged 13 commits into from
May 13, 2024

Conversation

unakb
Copy link
Member

@unakb unakb commented May 10, 2024

Ríksak - Saksóknari - Yfirlitssíða fyrir yfirlestur máls

What

Allow a public prosecutor to make a review decision in indictment cases

Screenshots / Gifs

Screen.Recording.2024-05-10.at.15.35.29.mov

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Formatting passes locally with my changes
  • I have rebased against main before asking for a review

Summary by CodeRabbit

  • New Features

    • Added a new field indictmentReviewDecision to case updates for managing indictment cases.
    • Introduced a review decision component for public prosecutors.
    • Included UI components and internationalized strings for reviewing decisions.
  • Bug Fixes

    • Updated access permissions for prosecution users to improve case handling.
  • Style

    • Implemented new CSS styles for the review decision grid layout.
  • Documentation

    • Enhanced clarity and internationalization in the indictment overview with updated strings.
  • Database Changes

    • Executed a database migration to support indictment review decisions.

Copy link
Contributor

coderabbitai bot commented May 10, 2024

Walkthrough

The recent updates in the judicial system software revolve around enhancing the handling of indictment review decisions. These changes introduce the IndictmentCaseReviewDecision enum and associated logic across various system components. This update streamlines the review and decision-making processes for public prosecutors, improving user interactions and data consistency.

Changes

File Path Change Summary
apps/judicial-system/api/src/app/modules/case-list/models/caseList.model.ts Removed CaseIndictmentRulingDecision import, impacting related logic.
apps/judicial-system/api/src/app/modules/case/dto/updateCase.input.ts, apps/judicial-system/backend/src/app/modules/case/dto/updateCase.dto.ts Added indictmentReviewDecision field to update case input classes.
apps/judicial-system/api/src/app/modules/case/models/case.model.ts, libs/judicial-system/types/src/lib/case.ts Added IndictmentCaseReviewDecision enum and related field to the Case class.
apps/judicial-system/backend/migrations/20240508231112-update-case.js Introduced database migration for indictment_review_decision column.
apps/judicial-system/backend/src/app/modules/case/filters/case.filter.ts, apps/judicial-system/backend/src/app/modules/case/guards/rolesRules.ts Updated access and role rules for new decision logic.
apps/judicial-system/web/src/routes/PublicProsecutor/Indictments/ReviewDecision/..., apps/judicial-system/web/src/routes/Shared/IndictmentOverview/IndictmentOverview.tsx Enhanced UI components for indictment review decisions with styles, strings, and interactive features.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

This comment was marked as off-topic.

@datadog-island-is

This comment was marked as off-topic.

@unakb unakb marked this pull request as ready for review May 10, 2024 15:45
@unakb unakb requested a review from a team as a code owner May 10, 2024 15:45
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Review Details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits Files that changed from the base of the PR and between 1e05ec6 and b6581dd.
Files selected for processing (15)
  • apps/judicial-system/api/src/app/modules/case-list/models/caseList.model.ts (1 hunks)
  • apps/judicial-system/api/src/app/modules/case/dto/updateCase.input.ts (2 hunks)
  • apps/judicial-system/api/src/app/modules/case/models/case.model.ts (3 hunks)
  • apps/judicial-system/backend/migrations/20240508231112-update-case.js (1 hunks)
  • apps/judicial-system/backend/src/app/modules/case/dto/updateCase.dto.ts (2 hunks)
  • apps/judicial-system/backend/src/app/modules/case/filters/case.filter.ts (1 hunks)
  • apps/judicial-system/backend/src/app/modules/case/guards/rolesRules.ts (1 hunks)
  • apps/judicial-system/backend/src/app/modules/case/models/case.model.ts (2 hunks)
  • apps/judicial-system/web/src/routes/PublicProsecutor/Indictments/ReviewDecision/ReviewDecision.css.ts (1 hunks)
  • apps/judicial-system/web/src/routes/PublicProsecutor/Indictments/ReviewDecision/ReviewDecision.strings.ts (1 hunks)
  • apps/judicial-system/web/src/routes/PublicProsecutor/Indictments/ReviewDecision/ReviewDecision.tsx (1 hunks)
  • apps/judicial-system/web/src/routes/Shared/IndictmentOverview/IndictmentOverview.strings.ts (1 hunks)
  • apps/judicial-system/web/src/routes/Shared/IndictmentOverview/IndictmentOverview.tsx (3 hunks)
  • libs/judicial-system/types/src/index.ts (1 hunks)
  • libs/judicial-system/types/src/lib/case.ts (1 hunks)
Files skipped from review due to trivial changes (3)
  • apps/judicial-system/web/src/routes/PublicProsecutor/Indictments/ReviewDecision/ReviewDecision.css.ts
  • apps/judicial-system/web/src/routes/PublicProsecutor/Indictments/ReviewDecision/ReviewDecision.strings.ts
  • apps/judicial-system/web/src/routes/Shared/IndictmentOverview/IndictmentOverview.strings.ts
Additional Context Used
Path-based Instructions (12)
apps/judicial-system/backend/migrations/20240508231112-update-case.js (1)

Pattern apps/**/*: "Confirm that the code adheres to the following:

  • NextJS best practices, including file structure, API routes, and static generation methods.
  • Efficient state management and server-side rendering techniques.
  • Optimal use of TypeScript for component and utility type safety."
libs/judicial-system/types/src/index.ts (1)

Pattern libs/**/*: "Confirm that the code adheres to the following:

  • Reusability of components and hooks across different NextJS apps.
  • TypeScript usage for defining props and exporting types.
  • Effective tree-shaking and bundling practices."
apps/judicial-system/api/src/app/modules/case-list/models/caseList.model.ts (1)

Pattern apps/**/*: "Confirm that the code adheres to the following:

  • NextJS best practices, including file structure, API routes, and static generation methods.
  • Efficient state management and server-side rendering techniques.
  • Optimal use of TypeScript for component and utility type safety."
apps/judicial-system/web/src/routes/PublicProsecutor/Indictments/ReviewDecision/ReviewDecision.tsx (1)

Pattern apps/**/*: "Confirm that the code adheres to the following:

  • NextJS best practices, including file structure, API routes, and static generation methods.
  • Efficient state management and server-side rendering techniques.
  • Optimal use of TypeScript for component and utility type safety."
apps/judicial-system/web/src/routes/Shared/IndictmentOverview/IndictmentOverview.tsx (1)

Pattern apps/**/*: "Confirm that the code adheres to the following:

  • NextJS best practices, including file structure, API routes, and static generation methods.
  • Efficient state management and server-side rendering techniques.
  • Optimal use of TypeScript for component and utility type safety."
apps/judicial-system/backend/src/app/modules/case/filters/case.filter.ts (1)

Pattern apps/**/*: "Confirm that the code adheres to the following:

  • NextJS best practices, including file structure, API routes, and static generation methods.
  • Efficient state management and server-side rendering techniques.
  • Optimal use of TypeScript for component and utility type safety."
apps/judicial-system/api/src/app/modules/case/dto/updateCase.input.ts (1)

Pattern apps/**/*: "Confirm that the code adheres to the following:

  • NextJS best practices, including file structure, API routes, and static generation methods.
  • Efficient state management and server-side rendering techniques.
  • Optimal use of TypeScript for component and utility type safety."
apps/judicial-system/backend/src/app/modules/case/dto/updateCase.dto.ts (1)

Pattern apps/**/*: "Confirm that the code adheres to the following:

  • NextJS best practices, including file structure, API routes, and static generation methods.
  • Efficient state management and server-side rendering techniques.
  • Optimal use of TypeScript for component and utility type safety."
libs/judicial-system/types/src/lib/case.ts (1)

Pattern libs/**/*: "Confirm that the code adheres to the following:

  • Reusability of components and hooks across different NextJS apps.
  • TypeScript usage for defining props and exporting types.
  • Effective tree-shaking and bundling practices."
apps/judicial-system/api/src/app/modules/case/models/case.model.ts (1)

Pattern apps/**/*: "Confirm that the code adheres to the following:

  • NextJS best practices, including file structure, API routes, and static generation methods.
  • Efficient state management and server-side rendering techniques.
  • Optimal use of TypeScript for component and utility type safety."
apps/judicial-system/backend/src/app/modules/case/guards/rolesRules.ts (1)

Pattern apps/**/*: "Confirm that the code adheres to the following:

  • NextJS best practices, including file structure, API routes, and static generation methods.
  • Efficient state management and server-side rendering techniques.
  • Optimal use of TypeScript for component and utility type safety."
apps/judicial-system/backend/src/app/modules/case/models/case.model.ts (1)

Pattern apps/**/*: "Confirm that the code adheres to the following:

  • NextJS best practices, including file structure, API routes, and static generation methods.
  • Efficient state management and server-side rendering techniques.
  • Optimal use of TypeScript for component and utility type safety."
Learnings (2)
apps/judicial-system/web/src/routes/PublicProsecutor/Indictments/ReviewDecision/ReviewDecision.tsx (1)
User: unakb
PR: island-is/island.is#14712
File: apps/judicial-system/web/src/routes/PublicProsecutor/Indictments/Overview/IndictmentOverview.tsx:0-0
Timestamp: 2024-05-06T18:09:27.876Z
Learning: The judicial system application uses a toaster notification system to handle errors globally.
apps/judicial-system/web/src/routes/Shared/IndictmentOverview/IndictmentOverview.tsx (1)
User: oddsson
PR: island-is/island.is#14673
File: apps/judicial-system/web/src/routes/PublicProsecutor/Tables/CasesForReview.tsx:79-79
Timestamp: 2024-05-06T23:16:04.892Z
Learning: The implementation of `mapIndictmentCaseStateToTagVariant` in `TagCaseState.tsx`, which maps only `CaseState.ACCEPTED` to a specific tag and defaults others to an "unknown" status, is intentional as per the application's requirements.
Additional comments not posted (14)
apps/judicial-system/backend/migrations/20240508231112-update-case.js (1)

4-16: Ensure transaction rollback on failure.

libs/judicial-system/types/src/index.ts (1)

57-57: Confirm usage of newly added exports.

Verification successful

The review of the usage of the newly added exports IndictmentCaseReviewDecision, isIndictmentCase, isRestrictionCase, and isInvestigationCase indicates that these are actively used across the application. They are defined in libs/judicial-system/types/src/lib/case.ts and are utilized in various functions within the same file. Additionally, their functionality is covered by unit tests in libs/judicial-system/types/src/lib/case.spec.ts, which further confirms their integration and usage.

  • IndictmentCaseReviewDecision is defined and used as an enum.
  • isIndictmentCase, isRestrictionCase, and isInvestigationCase are functions that are not only defined but also used in logical conditions and tested.

This confirms that the newly added exports are properly utilized across the application.

Scripts Executed

The following scripts were executed for the analysis:


Script:

#!/bin/bash
# Description: Verify the usage of newly added exports in the application.

# Test: Search for the usage of `IndictmentCaseReviewDecision` and related functions. Expect: Proper usage across the application.
rg --type ts 'IndictmentCaseReviewDecision|isIndictmentCase|isRestrictionCase|isInvestigationCase' 'libs/judicial-system/types/src'

Length of output: 1753

apps/judicial-system/api/src/app/modules/case-list/models/caseList.model.ts (1)

Line range hint 1-1: Confirm removal of CaseIndictmentRulingDecision import.

Verification successful

The search for CaseIndictmentRulingDecision in the specified directory did not return any results, confirming that this import has been successfully removed and is not used in the current file or elsewhere in the directory. This aligns with the review comment's request to verify the removal of this import.

Scripts Executed

The following scripts were executed for the analysis:


Script:

#!/bin/bash
# Description: Verify the removal of `CaseIndictmentRulingDecision` import and its impact.

# Test: Search for the usage of `CaseIndictmentRulingDecision`. Expect: No usage in the current file.
rg --type ts 'CaseIndictmentRulingDecision' 'apps/judicial-system/api/src/app/modules/case-list/models'

Length of output: 101

apps/judicial-system/web/src/routes/Shared/IndictmentOverview/IndictmentOverview.tsx (1)

107-125: Check conditional rendering logic for ReviewDecision and FormFooter.

Verification successful

The conditional rendering logic for ReviewDecision and FormFooter in IndictmentOverview.tsx is based on the condition shouldDisplayReviewDecision. This condition is defined to be true when the case is marked as completed (isCompletedCase(workingCase.state)) and the current user is the indictment reviewer (workingCase.indictmentReviewer?.id === user?.id). This logic ensures that these components are displayed only under appropriate circumstances, aligning with typical judicial review processes where only the reviewer of a completed case should proceed with certain actions.

Based on the verification, the implementation of this conditional rendering logic is correct and consistent with the intended functionality of the application.

Scripts Executed

The following scripts were executed for the analysis:


Script:

#!/bin/bash
# Description: Verify the conditional rendering logic for `ReviewDecision` and `FormFooter`.

# Test: Search for conditional rendering logic in `IndictmentOverview`. Expect: Correct conditions and rendering.
rg --type ts 'shouldDisplayReviewDecision' 'apps/judicial-system/web/src/routes/Shared/IndictmentOverview'

Length of output: 479



Script:

#!/bin/bash
# Description: Verify the definition and correctness of the condition `shouldDisplayReviewDecision`.

# Test: Search for the definition and usage of `shouldDisplayReviewDecision` in `IndictmentOverview.tsx`.
rg --type ts 'const shouldDisplayReviewDecision =' 'apps/judicial-system/web/src/routes/Shared/IndictmentOverview'

Length of output: 237



Script:

#!/bin/bash
# Description: Retrieve the full definition of `shouldDisplayReviewDecision`.

# Test: Extract the full line defining `shouldDisplayReviewDecision` in `IndictmentOverview.tsx`.
rg --type ts -N 'const shouldDisplayReviewDecision =' 'apps/judicial-system/web/src/routes/Shared/IndictmentOverview'

Length of output: 240



Script:

#!/bin/bash
# Description: Retrieve the full definition of `shouldDisplayReviewDecision`, ensuring complete line or block capture.

# Test: Use a broader search pattern to capture the entire definition block of `shouldDisplayReviewDecision` in `IndictmentOverview.tsx`.
rg --type ts -A 2 'const shouldDisplayReviewDecision =' 'apps/judicial-system/web/src/routes/Shared/IndictmentOverview'

Length of output: 506

apps/judicial-system/backend/src/app/modules/case/filters/case.filter.ts (1)

56-57: Validate access control logic for canProsecutionUserAccessCase.

Verification successful

The access control logic for canProsecutionUserAccessCase in the case.filter.ts file has been thoroughly reviewed. The function implements several checks to determine if a prosecution user can access a case:

  1. Role and Case Type Check: It first checks if the user's role is not a prosecutor and the case is not an indictment case, denying access if either condition is met.
  2. Case State Check: It ensures the case is in one of several specific states (e.g., NEW, DRAFT, WAITING_FOR_CONFIRMATION) before granting access.
  3. Prosecutors Office Access: It checks if the user's institution ID matches the case's prosecutors office ID or the shared prosecutors office ID, and if the user is not the indictment reviewer, access is denied.
  4. Heightened Security Level Access: Additional checks are likely implemented for cases with heightened security levels, though specifics are not shown in the snippet.

These conditions collectively ensure that only authorized prosecution users with relevant roles, case involvement, and correct institutional alignment can access the case details. The logic appears to be correctly implemented based on the provided snippets and the typical requirements for such access control systems in judicial environments.

Scripts Executed

The following scripts were executed for the analysis:


Script:

#!/bin/bash
# Description: Verify the access control logic for `canProsecutionUserAccessCase`.

# Test: Search for access control logic in `case.filter.ts`. Expect: Correct conditions and access control.
rg --type ts 'canProsecutionUserAccessCase' 'apps/judicial-system/backend/src/app/modules/case/filters'

Length of output: 352



Script:

#!/bin/bash
# Description: Retrieve the implementation of `canProsecutionUserAccessCase` from `case.filter.ts`.

# Extract the function implementation to analyze the access control logic.
rg --type ts -A 20 'const canProsecutionUserAccessCase = \(' 'apps/judicial-system/backend/src/app/modules/case/filters/case.filter.ts'

Length of output: 633



Script:

#!/bin/bash
# Description: Retrieve the continuation of the implementation of `canProsecutionUserAccessCase` from `case.filter.ts`.

# Extract the continuation of the function implementation to complete the analysis of the access control logic.
rg --type ts -A 20 -B 10 'CaseState.REJECTED,' 'apps/judicial-system/backend/src/app/modules/case/filters/case.filter.ts'

Length of output: 2865

apps/judicial-system/api/src/app/modules/case/dto/updateCase.input.ts (1)

383-384: Confirm the optional nature of indictmentReviewDecision.

Verification successful

The search results confirm that the indictmentReviewDecision field in the UpdateCaseInput class is indeed marked as optional (?), as indicated by the TypeScript syntax in the provided file snippet. This matches the expectation set in the review comment, verifying that the field is optional within the context of the UpdateCaseInput class.

Since the search was scoped to the directory containing the DTO definitions and only found the declaration itself without any other references or constraints that might suggest a different usage pattern, we can conclude that the optional nature of the field is consistent with its declaration.

Final Response:

The optional nature of indictmentReviewDecision in UpdateCaseInput is confirmed as per the declaration in the codebase.

  • Location: apps/judicial-system/api/src/app/modules/case/dto/updateCase.input.ts
Scripts Executed

The following scripts were executed for the analysis:


Script:

#!/bin/bash
# Description: Verify the optional nature of `indictmentReviewDecision` in `UpdateCaseInput`.

# Test: Search for usage of `indictmentReviewDecision`. Expect: Optional usage across the application.
rg --type ts 'indictmentReviewDecision' 'apps/judicial-system/api/src/app/modules/case/dto'

Length of output: 226

apps/judicial-system/backend/src/app/modules/case/dto/updateCase.dto.ts (1)

477-480: Ensure consistency in the use of IndictmentCaseReviewDecision.

Verification successful

The review of the usage of IndictmentCaseReviewDecision across the backend application indicates a consistent and correct implementation. This enum is used in both DTO and model files to define property types and is included in API property decorators, aligning with best practices for API documentation and runtime validations. No issues of inconsistency or incorrect usage were found.

  • File: apps/judicial-system/backend/src/app/modules/case/dto/updateCase.dto.ts
  • File: apps/judicial-system/backend/src/app/modules/case/models/case.model.ts
Scripts Executed

The following scripts were executed for the analysis:


Script:

#!/bin/bash
# Description: Verify the consistent use of `IndictmentCaseReviewDecision` in `UpdateCaseDto`.

# Test: Search for usage of `IndictmentCaseReviewDecision`. Expect: Consistent usage across the application.
rg --type ts 'IndictmentCaseReviewDecision' 'apps/judicial-system/backend/src/app/modules/case/dto'

Length of output: 587



Script:

#!/bin/bash
# Description: Verify the consistent use of `IndictmentCaseReviewDecision` across the entire backend application.

# Test: Search for usage of `IndictmentCaseReviewDecision` in the entire backend application to ensure there are no inconsistent usages or redefinitions.
rg --type ts 'IndictmentCaseReviewDecision' 'apps/judicial-system/backend/src'

Length of output: 1060

libs/judicial-system/types/src/lib/case.ts (1)

234-237: The addition of the IndictmentCaseReviewDecision enum is correctly implemented and follows TypeScript best practices.

apps/judicial-system/api/src/app/modules/case/models/case.model.ts (3)

21-21: The import of IndictmentCaseReviewDecision is correctly placed and necessary for the subsequent changes.


52-54: Registration of the IndictmentCaseReviewDecision enum for GraphQL is correctly implemented.


427-429: The addition of the indictmentReviewDecision field in the Case class is correctly implemented and follows the nullable pattern used in the class.

apps/judicial-system/backend/src/app/modules/case/guards/rolesRules.ts (1)

52-52: The addition of indictmentReviewDecision to the prosecutorFields array is appropriate and aligns with the role responsibilities.

apps/judicial-system/backend/src/app/modules/case/models/case.model.ts (2)

32-32: The addition of IndictmentCaseReviewDecision to the imports is correctly implemented. This ensures that the new enum is available for use in the model.


1258-1266: The implementation of the indictmentReviewDecision field in the Case model is correct. It is appropriately marked as optional and uses the newly introduced enum, which aligns with the changes described in the PR summary and AI-generated summary.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits Files that changed from the base of the PR and between b6581dd and 9fce80e.
Files selected for processing (3)
  • apps/judicial-system/web/src/routes/Court/Indictments/Conclusion/Conclusion.tsx (1 hunks)
  • apps/judicial-system/web/src/routes/PublicProsecutor/Indictments/ReviewDecision/ReviewDecision.tsx (1 hunks)
  • apps/judicial-system/web/src/routes/Shared/IndictmentOverview/IndictmentOverview.tsx (3 hunks)
Files skipped from review due to trivial changes (1)
  • apps/judicial-system/web/src/routes/Court/Indictments/Conclusion/Conclusion.tsx
Files skipped from review as they are similar to previous changes (2)
  • apps/judicial-system/web/src/routes/PublicProsecutor/Indictments/ReviewDecision/ReviewDecision.tsx
  • apps/judicial-system/web/src/routes/Shared/IndictmentOverview/IndictmentOverview.tsx

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Review Details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits Files that changed from the base of the PR and between 9fce80e and 812d7c5.
Files selected for processing (2)
  • apps/judicial-system/backend/src/app/modules/case/filters/cases.filter.ts (1 hunks)
  • apps/judicial-system/backend/src/app/modules/case/filters/test/cases.filter.spec.ts (2 hunks)
Files skipped from review due to trivial changes (1)
  • apps/judicial-system/backend/src/app/modules/case/filters/test/cases.filter.spec.ts
Additional Context Used
Path-based Instructions (1)
apps/judicial-system/backend/src/app/modules/case/filters/cases.filter.ts (1)

Pattern apps/**/*: "Confirm that the code adheres to the following:

  • NextJS best practices, including file structure, API routes, and static generation methods.
  • Efficient state management and server-side rendering techniques.
  • Optimal use of TypeScript for component and utility type safety."

Copy link
Member

@gudjong gudjong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One issue with case filters.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits Files that changed from the base of the PR and between 812d7c5 and 13600f5.
Files selected for processing (2)
  • apps/judicial-system/backend/src/app/modules/case/filters/cases.filter.ts (1 hunks)
  • apps/judicial-system/backend/src/app/modules/case/filters/test/cases.filter.spec.ts (2 hunks)
Files skipped from review as they are similar to previous changes (2)
  • apps/judicial-system/backend/src/app/modules/case/filters/cases.filter.ts
  • apps/judicial-system/backend/src/app/modules/case/filters/test/cases.filter.spec.ts

@unakb unakb requested a review from gudjong May 12, 2024 17:01
@gudjong gudjong added the automerge Merge this PR as soon as all checks pass label May 13, 2024
@kodiakhq kodiakhq bot merged commit 2887fbf into main May 13, 2024
45 checks passed
@kodiakhq kodiakhq bot deleted the j-s/complete-indictment-review branch May 13, 2024 09:57
Ballioli pushed a commit that referenced this pull request May 17, 2024
* feat(j-s): Complete indictment review

* feat(j-s): continued complete indictment review work

* Update updateCase.input.ts

* fix(j-s): cleanup

* feat(j-s): Set decision

* fix(j-s): cleanup

* fix(j-s): cleanup

* feat(j-s): Hide case from prosecutor reviewer list when review is finished

* fix filter
@coderabbitai coderabbitai bot mentioned this pull request Oct 7, 2024
6 tasks
@coderabbitai coderabbitai bot mentioned this pull request Oct 29, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge this PR as soon as all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants