Also return empty array if error.

island-is · Sep 19, 2024 · 562f5c2 · 562f5c2
1 parent 80ca07c
commit 562f5c2
Showing 1 changed file with 13 additions and 11 deletions.
diff --git a/libs/auth-api-lib/src/lib/delegations/delegation-scope.service.ts b/libs/auth-api-lib/src/lib/delegations/delegation-scope.service.ts
@@ -279,17 +279,19 @@ export class DelegationScopeService {
         `Failed checking if delegation exists at provider '${AuthDelegationProvider.DistrictCommissionersRegistry}'`,
       )
     }
-    if (!delegationFound && !isError) {
-      Promise.all(
-        delegationTypes.map((dt) =>
-          this.delegationsIndexService.removeDelegationRecord({
-            fromNationalId,
-            toNationalId,
-            type: dt as AuthDelegationType,
-            provider: AuthDelegationProvider.DistrictCommissionersRegistry,
-          }),
-        ),
-      )
+    if (!delegationFound) {
+      if (!isError) {
+        Promise.all(
+          delegationTypes.map((dt) =>
+            this.delegationsIndexService.removeDelegationRecord({
+              fromNationalId,
+              toNationalId,
+              type: dt as AuthDelegationType,
+              provider: AuthDelegationProvider.DistrictCommissionersRegistry,
+            }),
+          ),
+        )
+      }
       return []
     }