fix tests

island-is · Oct 11, 2024 · 2c865f5 · 2c865f5
1 parent 6fc9b6f
commit 2c865f5
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 6 deletions.
diff --git a/apps/services/auth/admin-api/src/app/v2/delegations/delegation-admin.controller.ts b/apps/services/auth/admin-api/src/app/v2/delegations/delegation-admin.controller.ts
@@ -105,13 +105,13 @@ export class DelegationAdminController {
   async createByZendeskId(
     @Body() { id }: ZendeskWebhookInputDto,
   ): Promise<void> {
-    await this.auditService.auditPromise(
+    await this.auditService.auditPromise<DelegationDTO>(
       {
         system: true,
         namespace,
         action: 'createByZendeskId',
         resources: (res) => {
-          return `id: ${res.id}, toNationalId: ${
+          return `id: ${res.id ?? 'Unknown'}, toNationalId: ${
             res.toNationalId ?? 'Unknown'
           }, fromNationalId: ${
             res.fromNationalId ?? 'Unknown'

diff --git a/apps/services/auth/admin-api/src/app/v2/delegations/test/delegation-admin.auth.spec.ts b/apps/services/auth/admin-api/src/app/v2/delegations/test/delegation-admin.auth.spec.ts
@@ -1,5 +1,4 @@
 import request from 'supertest'
-import bodyParser from 'body-parser'
 
 import {
   getRequestMethod,
@@ -12,8 +11,11 @@ import { User } from '@island.is/auth-nest-tools'
 import { FixtureFactory } from '@island.is/services/auth/testing'
 import { createCurrentUser } from '@island.is/testing/fixtures'
 import { DelegationAdminScopes } from '@island.is/auth/scopes'
-import { DelegationDTO, SequelizeConfigService } from '@island.is/auth-api-lib'
-import { DelegationAdminCustomService } from '@island.is/auth-api-lib'
+import {
+  DelegationAdminCustomService,
+  DelegationDTO,
+  SequelizeConfigService,
+} from '@island.is/auth-api-lib'
 
 import { AppModule } from '../../../app.module'
 import { includeRawBodyMiddleware } from '@island.is/infra-nest-server'
@@ -159,7 +161,16 @@ describe('withoutAuth and permissions', () => {
 
       jest
         .spyOn(delegationAdminService, 'createDelegationByZendeskId')
-        .mockImplementation(() => Promise.resolve())
+        .mockImplementation(() =>
+          Promise.resolve({
+            id: '123',
+            fromNationalId: '1234567890',
+            fromName: 'Test',
+            toNationalId: '0987654321',
+            toName: 'Test',
+            createdByNationalId: '0101010101',
+          } as DelegationDTO),
+        )
     })
 
     afterEach(() => {