Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #7135 (error with named argument "width") #7136

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

joseph-sch
Copy link

Type

Motivation and Context

Checklist:

  • I have run python util/check_style.py --apply to apply Open3D code style
    to my code.
  • This PR changes Open3D behavior or adds new functionality.
    • Both C++ (Doxygen) and Python (Sphinx / Google style) documentation is
      updated accordingly.
    • I have added or updated C++ and / or Python unit tests OR included test
      results
      (e.g. screenshots or numbers) here.
  • I will follow up and update the code if CI fails.
  • For fork PRs, I have selected Allow edits from maintainers.

Description

  • Add the missing comma before the first argument's name
  • Add the missing spaces in the function description

 * Add the missing comma before the first argument's name
 * Add the missing spaces in the function description
Copy link

update-docs bot commented Jan 13, 2025

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

@joseph-sch
Copy link
Author

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

I'd happily update the CHANGELOG.md file, but I don't think it's being maintained... so I wouldn't know where to add the change description, nor what good it would do...

@timohl
Copy link
Contributor

timohl commented Jan 14, 2025

Good catch and fix. :)

The last three lines in the docs are also corrupted:

(open3d.core.Device (device) – 0): Device of the create mesh.
optional – 0): Device of the create mesh.
default=CPU – 0): Device of the create mesh.

https://www.open3d.org/docs/latest/python_api/open3d.t.geometry.TriangleMesh.html#open3d.t.geometry.TriangleMesh.create_box

If it is no problem, can you check if your fix also resolves this?
Just a quick docs build and compare if it looks fine or not.
Otherwise, I can help looking into why it gets corrupted and we can fix that as well.

Copy link
Member

@ssheorey ssheorey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @joseph-sch ! Looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Named argument "width" not accepted by create_box in tensor API
3 participants