Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed draw_geometries to use default args instead of overload #7097

Merged
merged 2 commits into from
Dec 16, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Removed overload since default args serve this case already
timohl committed Dec 16, 2024
commit a0a3bcba09a2b6fe0a1b36a5975b6c9ac3c0ca9b
19 changes: 0 additions & 19 deletions cpp/pybind/visualization/utility.cpp
Original file line number Diff line number Diff line change
@@ -108,25 +108,6 @@ void pybind_visualization_utility_definitions(py::module &m) {
{"up", "The up vector of the camera."},
{"front", "The front vector of the camera."},
{"zoom", "The zoom of the camera."}};
m.def(
"draw_geometries",
[](const std::vector<std::shared_ptr<const geometry::Geometry>>
&geometry_ptrs,
const std::string &window_name, int width, int height, int left,
int top, bool point_show_normal, bool mesh_show_wireframe,
bool mesh_show_back_face) {
std::string current_dir =
utility::filesystem::GetWorkingDirectory();
DrawGeometries(geometry_ptrs, window_name, width, height, left,
top, point_show_normal, mesh_show_wireframe,
mesh_show_back_face);
utility::filesystem::ChangeWorkingDirectory(current_dir);
},
"Function to draw a list of geometry::Geometry objects",
"geometry_list"_a, "window_name"_a = "Open3D", "width"_a = 1920,
"height"_a = 1080, "left"_a = 50, "top"_a = 50,
"point_show_normal"_a = false, "mesh_show_wireframe"_a = false,
"mesh_show_back_face"_a = false);
m.def(
"draw_geometries",
[](const std::vector<std::shared_ptr<const geometry::Geometry>>