Merge branch 'develop/4.0' into 'master' #281
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How was this not already there?
DataParser should not be required to return Any and have objects checked for type safety at runtime. This allows us to use the Swift build time type checking system with very minimal changes to existing code. The only API breaking change is that Request classes using the default JSONDataParser should now conform to JSONRequest, instead of just Request. This is because protocol extensions cannot declare default associated types.
Add QueryParameters protocol to provide interface for URL query.
Data parser associated types
While the upload is in progress, `progressHandler` closure is periodically called. Therefore you can get information of uploading about `didSendBodyData` `totalBytesSent` `totalBytesExpectedToSend`. These parameters are defined by `urlSession(_:task:didSendBodyData:totalBytesSent:totalBytesExpectedToSend:)` in `URLSessionTaskDelegate`.
…apter` protocol.
Add a way to get progress of uploading.
Fix `progressHandler` to work properly
Rename Request.Parser to Request.DataParser
|
Checking in on this PR since this project seems unattended atm. Maybe I can propose a smaller PR to be merged? I was originally interested in #230 in particular so it might be good to start there. If there's no interest I'll just close this PR and stick with my forked master. Additionally: I'd happily sponsor this project if offered through GitHub Sponsors. Please consider enabling it for this repo :) |
|
Closing in favor of #305 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned here, some very useful changes were lost from
develop/4.0. This branch introduces these changes into master.They're breaking changes, so a major version update is required.
We can alternatively branch off master into
develop/6.0and merge these changes there but I fear the same loss may happen again this way.