Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#31 - Adds support for laravel mix 6 #33

Merged
merged 2 commits into from
Oct 28, 2021
Merged

#31 - Adds support for laravel mix 6 #33

merged 2 commits into from
Oct 28, 2021

Conversation

glennforrest
Copy link
Contributor

This PR adds support for laravel mix 6, as described in the following issue.

@ishanvyas22
Copy link
Owner

Hey @glennforrest, tests seems to be failing. Can you please check that and fix?

@glennforrest
Copy link
Contributor Author

Hey @ishanvyas22 , sorry for some reason tests just weren't on my mind 😅

Have pushed up a tweak for that

@ishanvyas22 ishanvyas22 added cake4 Specifies that the issue/pr is specific to master(cake4) branch enhancement New feature or request Hacktoberfest labels Oct 28, 2021
@ishanvyas22 ishanvyas22 merged commit a062f64 into ishanvyas22:master Oct 28, 2021
@ishanvyas22
Copy link
Owner

Thanks!

@ishanvyas22 ishanvyas22 mentioned this pull request Oct 28, 2021
Closed
@glennforrest
Copy link
Contributor Author

@ishanvyas22 No worries mate!

If you don't mind chucking the label hacktoberfest-accepted on the PR that'd be much appreciated.

Cheers!

@ishanvyas22
Copy link
Owner

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cake4 Specifies that the issue/pr is specific to master(cake4) branch enhancement New feature or request hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glennforrest @ishanvyas22