Conversation
📝 WalkthroughWalkthroughThree GB200 FP4 1k/8k recipe YAML configuration files are updated with a new container image version and FP4 GEMM backend settings are migrated from environment variables to sglang_config parameters. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
recipies/gb200-fp4/1k8k/max-tpt.yaml (1)
124-124: Potential typo:flashinfer_cutedslvsflashinfer_cutlass.The decode section uses
moe-runner-backend: "flashinfer_cutedsl"while the prefill section (line 73) usesmoe-runner-backend: "flashinfer_cutlass". Ifcutedslis a valid distinct backend for decode, please ignore. Otherwise, this may be a typo that should be corrected.recipies/gb200-fp4/1k8k/mid-curve.yaml (1)
125-125: Potential typo:flashinfer_cutedslvsflashinfer_cutlass.Same as
max-tpt.yaml—decode uses"flashinfer_cutedsl"while prefill (line 74) uses"flashinfer_cutlass". Please verify this is intentional.
|
@kyleliang-nv Can we change the containers to 0.3.8 later? The nightly images will be automatically deleted after 15 days |
Yes, I am aware that nightly containers are purged after certain days. I'm using the nightly container as a way to pin to an exact container until the 0.5.8 is released, then I'll switch the container to that one |
Be exact on which container to use.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.