Add sglang_router support for expert distribution recording#43
Closed
ishandhanani wants to merge 1 commit intomainfrom
Closed
Add sglang_router support for expert distribution recording#43ishandhanani wants to merge 1 commit intomainfrom
ishandhanani wants to merge 1 commit intomainfrom
Conversation
Collaborator
|
|
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for using
sglang_router.launch_routerinstead of the dynamo stack (NATS/ETCD/dynamo.frontend). This is the foundation for enabling expert distribution recording functionality.Key Changes
1. Configuration Layer
use_sglang_routerfield toBackendConfigschemause_sglang_router: truein their YAML configs2. Worker Command Building
command.pyto usesglang.launch_serverwhen eitheruse_profilingoruse_sglang_routeris enabled--port 30001and disaggregation settings3. Router Infrastructure
setup_sglang_router()function ininfrastructure.py--prefilland--decodeendpoints4. SLURM Template Updates
5. CLI Integration
routerworker type to worker_setup.py--use-sglang-routerflag support throughout the stack6. Example Configuration
examples/sglang-router-example.yamlwith complete working exampleArchitecture
When
use_sglang_router: true:sglang.launch_serverinstead ofdynamo.sglangUsage
Testing
Next Steps
This PR lays the foundation for Phase 2: expert distribution recording, which will add:
enable_expert_recordingconfiguration option🤖 Generated with Claude Code
Co-Authored-By: Claude noreply@anthropic.com