recipes: consolidate gb200 fp8 8k1k overrides#230
recipes: consolidate gb200 fp8 8k1k overrides#230weireweire wants to merge 1 commit intoishandhanani:mainfrom
Conversation
📝 WalkthroughWalkthroughAdded a new GB200-FP8 "8k1k" YAML recipe file with a shared base configuration containing Dynamo versioning, model/container settings, GPU topology, benchmark parameters, and sglang backend settings. Includes multiple override sections for different inference modes with tailored parallelism, scheduling, and speculative decoding parameters. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@recipes/gb200-fp8/8k1k.yaml`:
- Around line 4-7: Update the header comment map to match the actual recipe
keys: replace "override_lowlat" with "override_stp_lowlat" and
"zip_override_stp_curve" with "zip_override_stp_max_tpt", and also adjust
"override_lowlat_mtp" to the corresponding "override_stp_lowlat_mtp" if that key
exists in the recipe; leave "override_midcurve_mtp" as-is but verify it matches
the real key. Ensure the comment lines exactly mirror the real keys
(override_stp_lowlat, override_stp_lowlat_mtp, zip_override_stp_max_tpt,
override_midcurve_mtp) so future edits use the correct names.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 16f4af16-8635-406e-8977-a9cf4312acf2
📒 Files selected for processing (1)
recipes/gb200-fp8/8k1k.yaml
| # override_lowlat - STP low-latency | ||
| # override_lowlat_mtp - MTP low-latency | ||
| # zip_override_stp_curve - STP mid-curve + max-throughput | ||
| # override_midcurve_mtp - MTP mid-curve |
There was a problem hiding this comment.
Fix the section map in the header.
The comment still points to override_lowlat and zip_override_stp_curve, but the actual keys are override_stp_lowlat and zip_override_stp_max_tpt. That makes the recipe easy to edit incorrectly.
📝 Proposed fix
-# override_lowlat - STP low-latency
+# override_stp_lowlat - STP low-latency
# override_lowlat_mtp - MTP low-latency
-# zip_override_stp_curve - STP mid-curve + max-throughput
+# zip_override_stp_max_tpt - STP mid-curve + max-throughput
# override_midcurve_mtp - MTP mid-curve📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| # override_lowlat - STP low-latency | |
| # override_lowlat_mtp - MTP low-latency | |
| # zip_override_stp_curve - STP mid-curve + max-throughput | |
| # override_midcurve_mtp - MTP mid-curve | |
| # override_stp_lowlat - STP low-latency | |
| # override_lowlat_mtp - MTP low-latency | |
| # zip_override_stp_max_tpt - STP mid-curve + max-throughput | |
| # override_midcurve_mtp - MTP mid-curve |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@recipes/gb200-fp8/8k1k.yaml` around lines 4 - 7, Update the header comment
map to match the actual recipe keys: replace "override_lowlat" with
"override_stp_lowlat" and "zip_override_stp_curve" with
"zip_override_stp_max_tpt", and also adjust "override_lowlat_mtp" to the
corresponding "override_stp_lowlat_mtp" if that key exists in the recipe; leave
"override_midcurve_mtp" as-is but verify it matches the real key. Ensure the
comment lines exactly mirror the real keys (override_stp_lowlat,
override_stp_lowlat_mtp, zip_override_stp_max_tpt, override_midcurve_mtp) so
future edits use the correct names.
Summary
recipes/gb200-fp8/8k1k.yamloverride recipebaseand keep variant-specific topology/decode settings in overridesValidation
validate_config_file('recipes/gb200-fp8/8k1k.yaml')Summary by CodeRabbit