Skip to content
This repository was archived by the owner on Apr 20, 2026. It is now read-only.

feat: support dynamo 1.0.0 (--kv-transfer-config, ToT install for vllm - #220

Closed
qiching wants to merge 1 commit into
ishandhanani:mainfrom
qiching:feat/dynamo-1.0-vllm-support-v2
Closed

qiching wants to merge 1 commit into
ishandhanani:mainfrom
qiching:feat/dynamo-1.0-vllm-support-v2

Conversation

@qiching

@qiching qiching commented Mar 13, 2026

Copy link
Copy Markdown
Contributor

Summary

Updates srt-slurm to support dynamo 1.0.0, which introduces breaking changes to the connector CLI interface and requires install path fixes for vLLM containers.

Changes

1. --connector → --kv-transfer-config (src/srtctl/backends/vllm.py)

Dynamo 1.0.0 removed the --connector flag for the vLLM backend. Passing --connector nixl now raises:

ValueError: --connector is no longer supported for the vLLM backend.

The new equivalent is --kv-transfer-config with a JSON config. This PR automatically translates:

YAML config Old CLI (dynamo ≤0.9.1) New CLI (dynamo 1.0.0+)
connector: nixl --connector nixl --kv-transfer-config '{"kv_connector":"NixlConnector","kv_role":"kv_both"}'
connector: lmcache --connector lmcache --kv-transfer-config '{"kv_connector":"LMCacheConnectorV1","kv_role":"kv_both"}'
connector: none --connector none (no flag — default behavior)

Existing YAML configs using connector: nixl continue to work without changes.

2. Default dynamo version updated to 1.0.0 (src/srtctl/core/schema.py)

  • Default version: 0.8.0 → 1.0.0

3. ToT source install fixed for vLLM containers (src/srtctl/core/schema.py)

The previous source install path assumed SGLang containers (/sgl-workspace/, maturin, Rust toolchain). vLLM public containers don't have git, maturin, or Rust.

New approach:

  • Auto-installs git if not present
  • Clones to /tmp (universal path)
  • Installs ai-dynamo-runtime from PyPI (pre-built wheel, no Rust needed)
  • Installs ai-dynamo Python package from source
  • Works on both vLLM and SGLang containers

Related

@coderabbitai

coderabbitai Bot commented Mar 13, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 01beb94f-c4d5-456b-b404-044cd31554de

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can use Trivy to scan for security misconfigurations and secrets in Infrastructure as Code files.

Add a .trivyignore file to your project to customize which findings Trivy reports.

@qiching

qiching commented Mar 22, 2026

Copy link
Copy Markdown
Contributor Author

update PR for vllm side: #223

@qiching qiching closed this by deleting the head repository May 19, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant