Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip CodeRabbit can use Trivy to scan for security misconfigurations and secrets in Infrastructure as Code files.Add a .trivyignore file to your project to customize which findings Trivy reports. |
|
update PR for vllm side: #223 |
Summary
Updates srt-slurm to support dynamo 1.0.0, which introduces breaking changes to the connector CLI interface and requires install path fixes for vLLM containers.
Changes
1.
--connector→--kv-transfer-config(src/srtctl/backends/vllm.py)Dynamo 1.0.0 removed the
--connectorflag for the vLLM backend. Passing--connector nixlnow raises:ValueError:
--connectoris no longer supported for the vLLM backend.The new equivalent is
--kv-transfer-configwith a JSON config. This PR automatically translates:connector: nixl--connector nixl--kv-transfer-config '{"kv_connector":"NixlConnector","kv_role":"kv_both"}'connector: lmcache--connector lmcache--kv-transfer-config '{"kv_connector":"LMCacheConnectorV1","kv_role":"kv_both"}'connector: none--connector noneExisting YAML configs using
connector: nixlcontinue to work without changes.2. Default dynamo version updated to 1.0.0 (
src/srtctl/core/schema.py)0.8.0→1.0.03. ToT source install fixed for vLLM containers (
src/srtctl/core/schema.py)The previous source install path assumed SGLang containers (
/sgl-workspace/,maturin, Rust toolchain). vLLM public containers don't havegit,maturin, or Rust.New approach:
gitif not present/tmp(universal path)ai-dynamo-runtimefrom PyPI (pre-built wheel, no Rust needed)ai-dynamoPython package from sourceRelated
--connectorremoval: feat: remove --connector flag for vLLM backend (LLM-90) ai-dynamo/dynamo#6450--kv-transfer-configaddition: feat: add --kv-transfer-config NixlConnector to disagg scripts and recipes ai-dynamo/dynamo#6560