Skip to content
This repository was archived by the owner on Apr 20, 2026. It is now read-only.

Changing model_path to dsr1-fp8 for consistency for all STP SGLANg ac… #151

Merged
jgangani merged 2 commits into from
Feb 6, 2026
Merged

Changing model_path to dsr1-fp8 for consistency for all STP SGLANg ac… #151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d0d1cb3
Changing model_path to dsr1-fp8 for consistency for all STP SGLANg ac…
Feb 6, 2026
72193f2
lint fix
Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion recipes/gb300-fp8/1k1k/stp/low-latency.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: "gb300-1k1k-fp8-low-latency"

model:
path: "dsfp8"
path: "dsr1-fp8"
container: "lmsysorg/sglang:v0.5.8-cu130"
precision: "fp8"

Expand Down
2 changes: 1 addition & 1 deletion recipes/gb300-fp8/1k1k/stp/max.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
name: "gb300-1k1k-fp8-max"

model:
path: "dsfp8"
path: "dsr1-fp8"
container: "lmsysorg/sglang:v0.5.8-cu130"
precision: "fp8"

Expand Down
2 changes: 1 addition & 1 deletion recipes/gb300-fp8/1k1k/stp/mid.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
name: "gb300-1k1k-fp8-mid"

model:
path: "dsfp8"
path: "dsr1-fp8"
container: "lmsysorg/sglang:v0.5.8-cu130"
precision: "fp8"

Expand Down
2 changes: 1 addition & 1 deletion recipes/gb300-fp8/8k1k/stp/low-latency.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: "gb300-8k1k-fp8-low-latency"

model:
path: "dsfp8"
path: "dsr1-fp8"
container: "lmsysorg/sglang:v0.5.8-cu130"
precision: "fp8"

Expand Down
2 changes: 1 addition & 1 deletion recipes/gb300-fp8/8k1k/stp/max.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
name: "gb300-8k1k-fp8-max"

model:
path: "dsfp8"
path: "dsr1-fp8"
Comment on lines 5 to +6
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Check for any remaining references to the old "dsfp8" model path
echo "=== Files still referencing 'dsfp8' ==="
rg -rn 'dsfp8' --type yaml

echo ""
echo "=== All model path values in recipes/ for comparison ==="
rg -n 'path:' --type yaml -g 'recipes/**' | head -50

Repository: ishandhanani/srt-slurm

Length of output: 6155

🏁 Script executed:

#!/bin/bash
# More explicit search for the literal string "dsfp8"
echo "=== Direct literal search for 'dsfp8' ==="
rg 'dsfp8' --type yaml

echo ""
echo "=== GB300 fp8 recipes with STP variant ==="
fd . recipes/gb300-fp8 -type f -name "*.yaml" | grep stp

echo ""
echo "=== GB200 fp8 recipes with STP variant ==="
fd . recipes/gb200-fp8 -type f -name "*.yaml" | grep stp

Repository: ishandhanani/srt-slurm

Length of output: 2205

Address remaining dsfp8 references across the codebase.

The PR changes GB300-fp8 STP variants to use "dsr1-fp8", but 27 files still reference the old "dsfp8" path: 13 H100 files, 8 GB200-fp8 MTP files, and 6 GB300-fp8 MTP files. To achieve consistency across hardware variants and FP8 recipes as claimed in the PR title, update all stale references or clarify why certain variants should remain on the old path.

🤖 Prompt for AI Agents 
In `@recipes/gb300-fp8/8k1k/stp/max.yaml` around lines 5 - 6, Several files still
reference the old model path "dsfp8" while this recipe uses "dsr1-fp8"; search
the repo for all occurrences of "dsfp8" (the 27 reported files across H100,
GB200-fp8 MTP, and GB300-fp8 MTP variants) and update them to "dsr1-fp8" where
appropriate to match this PR, or add a clear comment in the specific files that
must remain on "dsfp8" explaining why they differ; ensure you update any YAML
keys, model.path references, and documentation strings referencing "dsfp8" so
they consistently use "dsr1-fp8" (or justify exceptions).

container: "lmsysorg/sglang:v0.5.8-cu130"
precision: "fp8"

Expand Down
2 changes: 1 addition & 1 deletion recipes/gb300-fp8/8k1k/stp/mid.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
name: "gb300-8k1k-fp8-mid"

model:
path: "dsfp8"
path: "dsr1-fp8"
container: "lmsysorg/sglang:v0.5.8-cu130"
precision: "fp8"

Expand Down
2 changes: 1 addition & 1 deletion src/srtctl/cli/setup_head.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,11 @@
import argparse
import logging
import os
import shutil
import subprocess
import sys
import time
from pathlib import Path
import shutil

# Network configurations
ETCD_CLIENT_PORT = 2379
Expand Down
Loading