Skip to content
This repository has been archived by the owner on Dec 29, 2022. It is now read-only.

is it possible to tell user about 'wrong username' issue? #20

Open
rahgurung opened this issue Dec 31, 2020 · 3 comments
Open

is it possible to tell user about 'wrong username' issue? #20

rahgurung opened this issue Dec 31, 2020 · 3 comments
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@rahgurung
Copy link

The error it currently gives will trick the user into thinking that error is from server-side, not user side.
Screenshot from 2020-12-31 10-21-51

faizanu94 added a commit to faizanu94/github-wrapped that referenced this issue Dec 31, 2020
@ishandeveloper
Copy link
Owner

Hey @gurrrung Thanks for creating this issue. The only reason that I did not pre-include an 'Invalid Username' error message was because the github api currently, does not send any error code that I could use to map a list of possible error messages.

For example : api.github.com/users/aprofilethatdoesnotexist

{
  "message": "Not Found",
  "documentation_url": "https://docs.github.com/rest/reference/users#get-a-user"
}

returns this String message

The something went wrong currently, in most of the cases would still be a username error but it could also be a server side error.

I'm not saying that we shouldn't fix this issue, we definitely need to, but instead of doing it on the client side, we could first have support for better error handling and responses from server side that we can render to the client. I'm labelling this as a bug, and I'm currently busy with some other commitments, so I might be able to work on this after a few days.

In case anyone is interested in working on this issue, please comment below and me or @himanshusharma89 will assign it to you.

Hope this helps. Happy New Year : )

@ishandeveloper ishandeveloper added bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed labels Jan 2, 2021
@APratham
Copy link

APratham commented Jan 2, 2021

@ishandeveloper I may be able to help with this if you like, and I also have a brief idea on how to go about it which I can share. It certainly can be an amazing feature for next year's GitHub wrapped.

@faizanu94
Copy link

@ishandeveloper I have made a pull request for this issue #22

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants