benchmark: convert to esm #319
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukekarrys
changed the title
lukekarrys
force-pushed
the
lk/fix-benchmarks
branch
2 times, most recently
from
2870afc
to
f70a86e
Compare
lukekarrys
force-pushed
the
lk/fix-benchmarks
branch
from
f70a86e
to
3109214
Compare
|
Closing in favor of #322 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was planning to benchmark #314 but ran into an issue where the benchmarks weren't running due to
ERR_REQUIRE_ESMerrors.I wasn't able to get../dist/commonjs/index.jsto require without error, so this PR creates apackage.jsonand.npmrcin the benchmarks directory sonpm installcan be run within that directory before the benchmarks are run.Ended up being easier to convert to ESM. My previous solution required
npm ito be run inside the directory when any local changes are made which is not ideal.