could u support a confirm prompt before del files? #134
Comments
|
@Froguard confirm dialogs would need to built into a UI, which would not be part of this module. |
|
@tmarshall ,it could occur in a command line like a REPL |
|
|
@Froguard sure, but this module is a utility. You can wrap it in a REPL module, but that should live outside of this repo |
|
Putting a dialog confirmation in this module is not really appropriate, and even checking for some kind of "onbeforedelete" callback would be prohibitively slow. Sorry, not the place. |
lukekarrys
added a commit
to lukekarrys/rimraf
that referenced
this issue
Oct 5, 2024
lukekarrys
added a commit
to lukekarrys/rimraf
that referenced
this issue
Oct 7, 2024
fix paths promise all dont sort randomize array order before rimraf dont use tmpdir test readdir contents in each loop sort fns move readdir back out faster testing for now try again more pr only just one file fallback to move remove on eperm trace trace 2 log error log in rimrafWindows log entries ci ci return true on eperm trace in windowsRemoveDir only log stack log catches make sure this still fails only one ci many times use fs.promises isaacs#134 trace entries fallback to move remove on eperm when getting dir entries fallback to move remove on eperm in fallback moar timeout timeout again refactor eperm integration test makes it show less TAP output and be configurable based on ci/local better errors in failing iterations only log leftover entries to error cause individual rimraf.windows errors await eperm and return true try without fs.promises add same behavior for windows sync end test properly trace on file eperm fix log things inside fix-eperm log less things
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
like a confirm dialog to remind users that it is a irreversibility opteartion
The text was updated successfully, but these errors were encountered: